New issue
Advanced search Search tips

Issue 721953 link

Starred by 1 user
Status: Fixed
Owner:
donnd@chromium.org
Closed: May 2017
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[TTS] A "re-tap" gesture is not being counted as a chained search (regression)

Project Member Reported by donnd@chromium.org, May 12 2017 
It looks like the refactoring for tap-text-extract in CL 2703473002 caused a regression in the panel metrics so now chained taps are not being counted as separate searches.  This will throw off our metrics, so it needs to be fixed soon.  

Investigating.  It looks like the previous implementation relied on animation start/finish to track the retap by calling setPanelState, but the new code evidently doesn't animate the panel on a retap so ContextualSearchPanelMetrics.onPanelStateChanged doesn't get called.
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4155a0bbd8b968baa44f8c9656e86e351b4e50a

commit b4155a0bbd8b968baa44f8c9656e86e351b4e50a
Author: donnd <donnd@chromium.org>
Date: Mon May 15 18:51:36 2017

[TTS] Fix metrics on re-tap to count both taps.

When the user taps next to the selection when the bar is already
showing the bar doesn't hide and reshow, but the searches are
considered separate. Currently we only update metrics for one
of these taps, but we're supposed to update for each search.

This change adds an override to ContextualSearchPanel to call
peekpanel when requestPanelShow is called in the case where it's
already peeking.

BUG= 721953 

Review-Url: https://codereview.chromium.org/2877063003
Cr-Commit-Position: refs/heads/master@{#471848}

[modify] https://crrev.com/b4155a0bbd8b968baa44f8c9656e86e351b4e50a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java

Comment 2 by donnd@chromium.org, May 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment