New issue
Advanced search Search tips

Issue 721949 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add tests for redirecting to hosted app URLs in subframes

Project Member Reported by creis@chromium.org, May 12 2017

Issue description

 Issue 715756  was a regression that reached stable channel because we had no tests for loading subframes that redirect to hosted app URLs.  We should add a test for this case.

Alex, would you be able to write one, to close the gap from  issue 697513  (where we noticed it affected data URLs with plugins but not hosted apps)?

(We're also hoping to remove the hosted apps process model in issue 721947, but that will probably take a while.)
 

Comment 1 by creis@chromium.org, May 16 2017

Labels: -Pri-2 Postmortem-Followup Pri-1
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a9cc5af57748545858620aab0e9cd8e24dcc93

commit c1a9cc5af57748545858620aab0e9cd8e24dcc93
Author: alexmos <alexmos@chromium.org>
Date: Fri May 19 00:12:53 2017

Add a test for subframes redirecting to hosted app URLs.

We recently had a regression that reached stable channel because we
had no tests for loading subframes that redirect to hosted app URLs.
This CL adds test coverage for that case.

BUG= 721949 ,  715756 

Review-Url: https://codereview.chromium.org/2891633002
Cr-Commit-Position: refs/heads/master@{#472986}

[modify] https://crrev.com/c1a9cc5af57748545858620aab0e9cd8e24dcc93/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Comment 4 by creis@chromium.org, May 19 2017

Status: Fixed (was: Started)
Thanks!

Sign in to add a comment