The critical update banner message is per-user. If user has migrated (e.g. is already using dircrypto), the banner will be hidden. And migration UI should not show up for those users too.

Video link: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/721948/File_000.mov?_ga=1.34415777.1204488054.1493153045

In the attached video, first 4 users in Row 1 are migrated. All the others are users are not yet migrated

Thanks for the video. It does look like a bug. For the same user, it should be consistent.

Can you attach logs if possible? Thanks.

Attached logs: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/721948/

This is because the last few users' cryptohome have been removed. Current impl would leave the banner as-is. Maybe we should clear the banner on this case. Since when those users sign in, their new cryptohome should be in new format.

Log:
[1491:1491:0512/142725.138761:ERROR:user_selection_screen.cc(202)] Failed to call cryptohome NeedsDircryptoMigration.

2017-05-12T14:27:25.115740-07:00 ERR cryptohomed[1465]: Unknown user.

https://codereview.chromium.org/2879333002/
Hide the banner on NeedsDircryptoMigration failure.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4

commit ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4
Author: xiyuan <xiyuan@chromium.org>
Date: Mon May 15 22:35:17 2017

cros: Hide banner on NeedsDircryptoMigration call failure

NeedsDircryptoMigration call fails when user cryptohome is removed.
Leaving banner status unchanged is confusing. Hide the banner when
this happens to make UI consistent.

BUG= 721948 

Review-Url: https://codereview.chromium.org/2879333002
Cr-Commit-Position: refs/heads/master@{#471928}

[modify] https://crrev.com/ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4/chrome/browser/chromeos/login/screens/user_selection_screen.cc

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f07c0bcb088e515f8f252bb10c2e4e9bfa4a80

commit 29f07c0bcb088e515f8f252bb10c2e4e9bfa4a80
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed May 17 16:15:59 2017

Merge "cros: Hide banner on NeedsDircryptoMigration call failure"

> NeedsDircryptoMigration call fails when user cryptohome is removed.
> Leaving banner status unchanged is confusing. Hide the banner when
> this happens to make UI consistent.
>
> BUG= 721948 
>
> Review-Url: https://codereview.chromium.org/2879333002
> Cr-Commit-Position: refs/heads/master@{#471928}
> (cherry picked from commit ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4)

Review-Url: https://codereview.chromium.org/2886083003 .
Cr-Commit-Position: refs/branch-heads/3071@{#598}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/29f07c0bcb088e515f8f252bb10c2e4e9bfa4a80/chrome/browser/chromeos/login/screens/user_selection_screen.cc