Height of infobar should match the height of Contextual Search (50) |
|||
Issue descriptionChrome Version: 60+ OS: Android Step to reproduce: enable new UI Leo - We got some feedback that it'd be better if the bar height would be consistent with the Home bar and the Contextual Search bar. Can we seamlessly change the height bar to 50 without messing up alignment? If not, let's hold off and implement this later. If yes, let's implement now.
,
May 23 2017
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/508b1baa57fe9c5f0751a873a3e2e9ac87cf1ffa commit 508b1baa57fe9c5f0751a873a3e2e9ac87cf1ffa Author: googleo <googleo@chromium.org> Date: Tue May 23 15:47:40 2017 Fix compact infobar height to match the height of Contextual Search. BUG= 721943 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2884563002 Cr-Commit-Position: refs/heads/master@{#473915} [modify] https://crrev.com/508b1baa57fe9c5f0751a873a3e2e9ac87cf1ffa/chrome/android/java/res/values/dimens.xml
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a9900ea47c031e6c1f32e5fef106a1844361c61 commit 1a9900ea47c031e6c1f32e5fef106a1844361c61 Author: googleo <googleo@chromium.org> Date: Wed May 24 23:22:23 2017 Fix compact infobar's content height. We enlarged compact infobar's height to 56dp, which causes extra space inside. https://screenshot.googleplex.com/Di57pyX4Q37 This change will keep its content as same as the container. Screenshot after fixed: https://screenshot.googleplex.com/ECaQVWg6rGJ BUG= 721943 Review-Url: https://codereview.chromium.org/2903793002 Cr-Commit-Position: refs/heads/master@{#474470} [modify] https://crrev.com/1a9900ea47c031e6c1f32e5fef106a1844361c61/chrome/android/java/res/layout/infobar_translate_compact_content.xml
,
Jun 20 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by goog...@chromium.org
, May 12 2017