New issue
Advanced search Search tips

Issue 721933 link

Starred by 2 users
Status: Fixed
Owner:
bashi@chromium.org
Closed: May 2017
Cc:
nhiroki@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

run-bindings-tests failing "Enumeration RequestCredentials has multiple definitions"

Project Member Reported by jsb...@chromium.org, May 12 2017 
third_party/WebKit/Tools/Scripts/run-bindings-tests

27 tests run, 0 failures.
Traceback (most recent call last):
... snip ...
Exception: Enumeration RequestCredentials has multiple definitions

Comment 1 by bashi@chromium.org, May 15 2017

Cc: nhiroki@chromium.org
Owner: bashi@chromium.org
Status: Available (was: Untriaged)
Thanks for filing the bug. https://codereview.chromium.org/2868413005 added a dup of RequestCredentials. (Just to be clear nhiroki@ just followed my suggestion and I am to blame)

A possible workaround is to check the enum has the same members. I'll take closer look tomorrow.

Comment 2 by bashi@chromium.org, May 15 2017 

 Issue 722162  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c2711c305b811722270723ad12e11d52f7acef

commit 43c2711c305b811722270723ad12e11d52f7acef
Author: bashi <bashi@chromium.org>
Date: Mon May 15 21:44:36 2017

bindings: Allow multiple enum declarations

crrev.com/2868413005 added a dup of an IDL enum to work around
core/module separation. We need to allow multiple enum declarations
if they have the same valid values.

BUG= 721933 

Review-Url: https://codereview.chromium.org/2887453003
Cr-Commit-Position: refs/heads/master@{#471912}

[modify] https://crrev.com/43c2711c305b811722270723ad12e11d52f7acef/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

Comment 4 by bashi@chromium.org, May 15 2017

Status: Fixed (was: Available)

Comment 5 by jsb...@chromium.org, May 15 2017 

Awesome, thanks!

Comment 6 by nhiroki@chromium.org, May 16 2017 

Thank you, bashi-san!
►

Sign in to add a comment