New issue
Advanced search Search tips

Issue 721923 link

Starred by 1 user
Status: Fixed
Owner:
einbinder@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

DevTools elements panel selected item not readable

Project Member Reported by esprehn@chromium.org, May 12 2017 
Google Chrome	60.0.3096.0 (Official Build) canary (64-bit)
Revision	c714b929856634f69e66588db294ccb8b785ad25-refs/heads/master@{#470759}
OS	Mac OS X
JavaScript	V8 6.0.189

What steps will reproduce the problem?
(1) Go to a site that contains some <style> elements that contain urls.
(2) Open the devtools and select the text inside the <style>
elements-panel-style.png
20.3 KB View Download

Comment 1 by l...@chromium.org, May 18 2017

Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
einbinder@, could you please take a look?
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67b9397be98e2a87643584013dee61417c5e45b2

commit 67b9397be98e2a87643584013dee61417c5e45b2
Author: Joel Einbinder <einbinder@chromium.org>
Date: Tue Oct 31 01:58:31 2017

DevTools: Move default CodeMirror theme into cmdevtools.css

Moving the default theme to stop fighting these styles with !important and
fixes a of css bugs.

This is a change to our CodeMirror rolling policy, which is now located
at front_end/cm/README.md

Bug:  721923 
Change-Id: I9a0a729ecd338b4c18579bf0f6b5d3ee552a54ea
Reviewed-on: https://chromium-review.googlesource.com/744734
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512716}
[modify] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/third_party/WebKit/Source/devtools/front_end/cm/PRESUBMIT.py
[add] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/third_party/WebKit/Source/devtools/front_end/cm/README.md
[modify] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/third_party/WebKit/Source/devtools/front_end/cm/codemirror.css
[modify] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/third_party/WebKit/Source/devtools/front_end/cm_modes/PRESUBMIT.py
[modify] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css
[modify] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
[modify] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlightDark.css

Comment 3 by einbinder@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)

Comment 4 by susanjuniab@chromium.org, Nov 1 2017

Labels: Needs-Feedback
esprehn@ Could you please provide us the sample URL and detailed repro steps with expected and actual results to verify the issue from TE-end.


Thanks..
►

Sign in to add a comment