New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721916 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

There is no space between text and “Accept & Continue” button in welcome screen.

Project Member Reported by vbhatso...@chromium.org, May 12 2017

Issue description

App Version: 59.0.3.71.50 beta
iOS Version: iOS 9.3.5
Device : iPhone 4 Only
 

Steps to reproduce:
 
1- Clean Install , Launch chrome.
 
 
Observed results:
There is no space between text and “Accept & Continue” button in welcome screen
 
 
Expected results:
There should be space between text and “Accept & Continue” button in welcome screen
 
Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on current stable build (App Version, iOS Version):Yes- M58
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M59
 
Link: 
https://drive.google.com/open?id=0B6GVWQnhaMClSFFXREpKRHlzUXc

 

Comment 1 by sczs@chromium.org, May 17 2017

Labels: M-60
Owner: lod@chromium.org
Status: Assigned (was: Untriaged)
Hi lod@ could you please take a look at this issue. You did some previous work on this, so I hope you're the right person

Comment 2 by lod@chromium.org, May 31 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a05953afa5a5f242d4f00fc994a3f3acab185e3

commit 8a05953afa5a5f242d4f00fc994a3f3acab185e3
Author: lod <lod@chromium.org>
Date: Thu Jun 01 16:56:27 2017

Fix spacing on welcome screen for small screen (iPhone 4)

Shift the welcome screen contents up to allow for correct spacing when
the full screen size is too small to align the contents in the center
and the bottom button with the button on the next screen.

BUG= 721916 

Review-Url: https://codereview.chromium.org/2914013002
Cr-Commit-Position: refs/heads/master@{#476326}

[modify] https://crrev.com/8a05953afa5a5f242d4f00fc994a3f3acab185e3/ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm

Comment 4 by lod@chromium.org, Jun 1 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on iOS 9.3.5 iPhone 4 on build 61.0.3122.0 canary

Sign in to add a comment