New issue
Advanced search Search tips

Issue 721912 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Site Isolation FYI bots failing http/tests/intersection-observer/cross-origin-iframe-with-nesting.html

Project Member Reported by creis@chromium.org, May 12 2017

Issue description

As of https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/16495, all builds on the Site Isolation Linux FYI bot are failing the http/tests/intersection-observer/cross-origin-iframe-with-nesting.html layout test.  Same on Site Isolation Win FYI.

There isn't much useful in the test output, but it seems related to https://codereview.chromium.org/2845583002.  kenrb@ is taking a look; we should disable or revert to get the bot green.
 

Comment 1 by kenrb@chromium.org, May 12 2017

I have verified that the regression was caused by r471225.

I think this fixes it: https://codereview.chromium.org/2880043003/
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/204a990c6d1d1cb9a72f50fe1a0639b0c176351d

commit 204a990c6d1d1cb9a72f50fe1a0639b0c176351d
Author: kenrb <kenrb@chromium.org>
Date: Sat May 13 00:22:30 2017

Correct location adjustment in FrameView::ConvertSelfToChild

r471225 removed a negation in the translation of a point between frame
coordinate spaces. This CL restores the negation.

BUG= 721912 

Review-Url: https://codereview.chromium.org/2880043003
Cr-Commit-Position: refs/heads/master@{#471506}

[modify] https://crrev.com/204a990c6d1d1cb9a72f50fe1a0639b0c176351d/third_party/WebKit/Source/core/frame/FrameView.cpp

Comment 3 by kenrb@chromium.org, May 13 2017

Status: Fixed (was: Assigned)

Sign in to add a comment