FullscreenWebContentActivityTest#testExitOnBack seems to be flaky (chrome_public_test_apk failing on 2 builders) |
||||
Issue descriptionIt's recently added FullscreenWebContentActivityTest#testExitOnBack. Fails for me locally too :/ chrome_public_test_apk failing on 2 builders Builders failed on: - Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests - Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29
,
May 12 2017
The logs, in case they get lost: C 16.733s Main ******************************************************************************** C 16.733s Main Detailed Logs C 16.733s Main ******************************************************************************** C 16.734s Main [FAIL] org.chromium.chrome.browser.FullscreenWebContentsActivityTest#testExitOnBack: C 16.734s Main junit.framework.AssertionFailedError: Criteria not met in allotted time. C 16.734s Main at junit.framework.Assert.fail(Assert.java:50) C 16.734s Main at junit.framework.Assert.assertTrue(Assert.java:20) C 16.734s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) C 16.734s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) C 16.734s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138) C 16.734s Main at org.chromium.chrome.browser.FullscreenWebContentsActivityTest.waitForActivity(FullscreenWebContentsActivityTest.java:114) C 16.734s Main at org.chromium.chrome.browser.FullscreenWebContentsActivityTest.testExitOnBack(FullscreenWebContentsActivityTest.java:149) C 16.734s Main at java.lang.reflect.Method.invoke(Native Method) C 16.734s Main at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) C 16.734s Main at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) C 16.734s Main at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) C 16.735s Main at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) C 16.735s Main at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) C 16.735s Main at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) C 16.735s Main at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) C 16.735s Main at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:59) C 16.735s Main at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) C 16.735s Main at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) C 16.735s Main at org.chromium.chrome.test.ChromeActivityTestRule$2.evaluate(ChromeActivityTestRule.java:66) C 16.735s Main at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) C 16.735s Main at org.junit.rules.RunRules.evaluate(RunRules.java:20) C 16.735s Main at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) C 16.735s Main at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) C 16.735s Main at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:135) C 16.735s Main at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:36) C 16.735s Main at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) C 16.735s Main at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) C 16.735s Main at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) C 16.735s Main at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) C 16.736s Main at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) C 16.736s Main at org.junit.runners.ParentRunner.run(ParentRunner.java:363) C 16.736s Main at org.junit.runners.Suite.runChild(Suite.java:128) C 16.736s Main at org.junit.runners.Suite.runChild(Suite.java:27) C 16.736s Main at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) C 16.736s Main at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) C 16.736s Main at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) C 16.736s Main at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) C 16.736s Main at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) C 16.736s Main at org.junit.runners.ParentRunner.run(ParentRunner.java:363) C 16.736s Main at org.junit.runner.JUnitCore.run(JUnitCore.java:137) C 16.736s Main at org.junit.runner.JUnitCore.run(JUnitCore.java:115) C 16.736s Main at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) C 16.736s Main at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) C 16.736s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2068) C 16.736s Main ******************************************************************************** C 16.736s Main Summary C 16.736s Main ******************************************************************************** C 16.737s Main [==========] 1 test ran. C 16.737s Main [ PASSED ] 0 tests. C 16.737s Main [ FAILED ] 1 test, listed below: C 16.737s Main [ FAILED ] org.chromium.chrome.browser.FullscreenWebContentsActivityTest#testExitOnBack C 16.737s Main C 16.737s Main 1 FAILED TEST C 16.737s Main ********************************************************************************
,
May 12 2017
per the flakiness dashboard (https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.FullscreenWebContentsActivityTest%23testExitOnBack), this started appearing ~ 00:00 PDT 2017-05-12. https://codereview.chromium.org/2842693005 is one of few CLs in the blamelists of the first wave of failures, and one of its tryjobs flaked on this test. I'm wondering if it's related.
,
May 15 2017
I also noticed it while landing https://codereview.chromium.org/2842693005 but dismissed it as a random flakiness. Testing with/without the CL makes me think it is related. I'll look into it.
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3577357065de1e5a173163335406faa28932c07c commit 3577357065de1e5a173163335406faa28932c07c Author: jinsukkim <jinsukkim@chromium.org> Date: Thu May 18 05:58:35 2017 Fix a bug in updating physical backing size |physical_size_| in ViewAndroid objects are valid from wcva down, while that in WindowAndroid is empty and not used. When adding a child, Empty physical size should not be propagated down since it can overwrite valid size in the children. It handles WindowAndroid case as well, in more general fashion. This changes fixes the test that became flaky by https://crrev.com/2842693005. BUG= 721906 Review-Url: https://codereview.chromium.org/2890713002 Cr-Commit-Position: refs/heads/master@{#472694} [modify] https://crrev.com/3577357065de1e5a173163335406faa28932c07c/chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenWebContentsActivityTest.java [modify] https://crrev.com/3577357065de1e5a173163335406faa28932c07c/ui/android/view_android.cc
,
May 18 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 12 2017