login_manager: migrate UMA stats away from X timings |
||||||
Issue descriptionwe have these two uma stats today: * ProcessesTerminatedToXTerminatedAfterLogout: other-processes-terminated -> x-terminated * XTerminatedToChromeExecAfterLogout: x-terminated -> chrome-exec since X no longer exists, other-processes-terminated and x-terminated are the same. which means the deltas aren't useful. ideally we'd create a new stat two replace these two like: * ProcessesTerminatedToChromeExecAfterLogout: other-processes-terminated -> chrome-exec not sure what all dashboards people are using. or maybe we just make these changes and see if anyone notices ? :) - update the Chrome histogram XML to list the new data point - change login_manager/init/scripts/send-uptime-metrics to only log this new point
,
May 14 2018
This would probably be a good, quick Noogler bug for learning how to build/change platform2 code.
,
May 21 2018
,
May 22 2018
,
May 23 2018
I'm going to start emitting the new metric separately from removing the old metrics. That way there should be some overlap in UMA if someone wants to compare the metrics across the change.
,
May 31 2018
It appears that the old counter names are no longer in service. After also considering the ChromeOS revision cycle, I'm going to delete the old counters right away.
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4acd617c88bdba2c645bc5587b2b9ec413a44f4b commit 4acd617c88bdba2c645bc5587b2b9ec413a44f4b Author: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Date: Sat Jun 02 00:44:43 2018 login: Add a Freon-apropos shutdown timing statistic. ... and delete the obsolete ones. BUG= chromium:721891 TEST=Manually verified on coral by observing chrome://histograms/Uptime after a login/logout/login cycle. Change-Id: Id2b698ca937df6aa9316ec27a1db8c63ec3a36b8 Reviewed-on: https://chromium-review.googlesource.com/1070496 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Benjamin Gordon <bmgordon@chromium.org> [modify] https://crrev.com/4acd617c88bdba2c645bc5587b2b9ec413a44f4b/login_manager/init/scripts/send-uptime-metrics
,
Jun 4 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b86c1f81b402a50c5a1b38a909d587244601114 commit 3b86c1f81b402a50c5a1b38a909d587244601114 Author: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Date: Wed Jun 06 18:05:50 2018 Update histograms for ChromeOS Uptime metrics. BUG= chromium:721891 Change-Id: Ief16bef5e035b3a8cc767395cd220938c7cbf329 Reviewed-on: https://chromium-review.googlesource.com/1081428 Commit-Queue: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#564965} [modify] https://crrev.com/3b86c1f81b402a50c5a1b38a909d587244601114/tools/metrics/histograms/histograms.xml
,
Jun 7 2018
,
Jun 11 2018
Nice work Jonathan! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, May 14 2018Status: Untriaged (was: Available)