New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721882 link

Starred by 1 user
Status: Fixed
Owner:
█ hjd@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
erikc...@chromium.org
primiano@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename cmm_private_footprint in memory_instrumentation.mojom

Project Member Reported by erikc...@chromium.org, May 12 2017 
Both this and some other nits were brought up in code review for https://codereview.chromium.org/2867213003/. The code itself is otherwise fine, and is blocking other code that the memory UMA team is trying to get in soon. I'm going to send the CL through the CQ and let hjd clean up when he gets back in.
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df95d5dffe9aa1d9969f097baf40552fa13eea3b

commit df95d5dffe9aa1d9969f097baf40552fa13eea3b
Author: erikchen <erikchen@chromium.org>
Date: Sun May 14 16:37:43 2017

memory-infra: Assemble dump results in service

This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written
by hjd@. I fixed some issues and addressed some nits as well.

> Do two new things:
> 1) Compute private memory footprint in a platform specific way.
> 2) Match up OSMemDumps with the correct ChromeMemDump.
>
> Both of these require a bit more work, we need to get the correct
> PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS,
> improved on OSX and checked on Android.

BUG=703184,  721882 
TBR=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2876733005
Cr-Commit-Position: refs/heads/master@{#471630}

[modify] https://crrev.com/df95d5dffe9aa1d9969f097baf40552fa13eea3b/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/df95d5dffe9aa1d9969f097baf40552fa13eea3b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

Comment 2 by hjd@chromium.org, May 15 2017

Cc: erikc...@chromium.org
Status: Fixed (was: Assigned)
I think you addressed all the comments in the end right?
►

Sign in to add a comment