Migrate PPAPI CDM related UMA when switching to mojo CDM |
||||
Issue descriptionCurrently we have many EME/CDM related UMAs tied to the PPAPI path. We should migrate them before we switch to mojo CDM. I'll grab a list of UMAs that need to be migrated and update this issue with it.
,
Oct 10 2017
,
Oct 10 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c4c960053696c2a74aa0b59b55b87e110d13754 commit 6c4c960053696c2a74aa0b59b55b87e110d13754 Author: Xiaohan Wang <xhwang@chromium.org> Date: Wed Oct 11 20:41:07 2017 media: Report Media.EME.CdmInterfaceVersion UMA in CdmAdapter Currently this is reported in ppapi_cdm_adapter.cc. As we are moving from pepper CDM to mojo CDM (using CdmAdapter), also report this UMA in CdmAdapter. Note that pre-submit script is skipped due to crbug.com/772494 NOPRESUBMIT=true BUG= 721876 TEST=Manually tested and checked about://histograms Change-Id: I51f4b1a7dc170fd0b516233da25c43d19387d67b Reviewed-on: https://chromium-review.googlesource.com/709470 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#508099} [modify] https://crrev.com/6c4c960053696c2a74aa0b59b55b87e110d13754/media/cdm/cdm_adapter.cc
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eb1d376259ba383ecbc9f912b2964dd04c3f756 commit 0eb1d376259ba383ecbc9f912b2964dd04c3f756 Author: Xiaohan Wang <xhwang@chromium.org> Date: Thu Oct 19 22:53:58 2017 media: Report promise rejection system code UMA in CdmAdapter Currently this UMA is reported in ContentDecryptorDelegate which is only used in the pepper CDM path. This CL makes sure we report the same UMA in the mojo CDM path as well. TBR=bbudge@chromium.org BUG= 412987 , 721876 TEST=Manually tested and checked about://histograms Change-Id: I4687e5115ee6d03e6a2701250bae50acf2dec2a8 Reviewed-on: https://chromium-review.googlesource.com/727700 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#510246} [modify] https://crrev.com/0eb1d376259ba383ecbc9f912b2964dd04c3f756/content/renderer/pepper/content_decryptor_delegate.cc [modify] https://crrev.com/0eb1d376259ba383ecbc9f912b2964dd04c3f756/media/cdm/cdm_adapter.cc
,
Oct 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a010f5449ed3fbfa6fa988289edab000fe5c395 commit 5a010f5449ed3fbfa6fa988289edab000fe5c395 Author: Xiaohan Wang <xhwang@chromium.org> Date: Sat Oct 28 05:58:20 2017 media: Add CDM loading UMAs This CL adds 3 UMAs about CDM loading when using mojo CDM: - Media.EME.CdmLoadResult - Media.EME.CdmLoadErrorCode - Media.EME.CdmLoadTime These will replace the current pepper plugin load UMAs whic is reported when using pepper CDMs, which will be removed in the future when PPAPI is deprecated: - Plugin.PpapiPluginLoadResult_<cdm adapter name> - Plugin.PpapiPluginLoadErrorCode_<cdm adapter name> - Plugin.PpapiPluginLoadTime_<cdm adapter name> Note that the load result enum is slightly different. INIT_FAILED does not exist anymore because InitializeCdmModule() is called in a different function. It is not really related to CDM loading and pretty much never fail, so it should be okay not to report it. Using NOPRESUBMIT=true due to crbug.com/772494. NOPRESUBMIT=true BUG= 721876 TEST=Manually tested and checked about://histograms Change-Id: If0a4478844b5321409c09952e1ff23b9a545ec30 Reviewed-on: https://chromium-review.googlesource.com/742688 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512385} [modify] https://crrev.com/5a010f5449ed3fbfa6fa988289edab000fe5c395/media/cdm/cdm_module.cc [modify] https://crrev.com/5a010f5449ed3fbfa6fa988289edab000fe5c395/tools/metrics/histograms/enums.xml [modify] https://crrev.com/5a010f5449ed3fbfa6fa988289edab000fe5c395/tools/metrics/histograms/histograms.xml
,
Nov 2 2017
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d467c1678dd399766be047d8bf4d909c4ca4543 commit 3d467c1678dd399766be047d8bf4d909c4ca4543 Author: Xiaohan Wang <xhwang@chromium.org> Date: Thu Nov 02 22:08:59 2017 media: Report Media.EME.OutputProtection UMA in CdmAdapter This UMA is currently reported in PpapiCdmAdapter. Adding the same UMA to (mojo) CdmAdapter so that we report the data in both cases. Using NOPRESUBMIT=true due to crbug.com/772494. NOPRESUBMIT=true BUG= 721876 Change-Id: I9b48973f12604445921d909238c726e1ef444f5b Reviewed-on: https://chromium-review.googlesource.com/742493 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#513614} [modify] https://crrev.com/3d467c1678dd399766be047d8bf4d909c4ca4543/media/cdm/cdm_adapter.cc [modify] https://crrev.com/3d467c1678dd399766be047d8bf4d909c4ca4543/media/cdm/cdm_adapter.h
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83a6f4d54685ab63c586b6f14c8e224778493e6b commit 83a6f4d54685ab63c586b6f14c8e224778493e6b Author: Xiaohan Wang <xhwang@chromium.org> Date: Fri Nov 03 17:57:20 2017 media: Report first file read size UMA in CdmAdapter Report the size of the first read file in CdmAdapter. Note that in a CdmAdapter object, we could have multiple cdm::FileIO objects created. However, we only report the size of the first file read across all cdm::FileIO objects, to be consistent with the current UMA reported in PpapiCdmAdapter. Also, if a promise is rejected due to file related errors, we report Media.EME.CdmFileIO.FileSizeKBOnError UMA with the size of the latest read file. There might be a slight chance where the file size reported is actually not the file causing the error, but that should be very rare. Media.EME.CdmFileIO.FileSizeKBOnError reporting is removed from PpapiCdmAdapter because it's problematic. See crbug.com/780664 for details. BUG= 721876 , 780664 TEST=Manually tested and checked about://histograms Change-Id: I301880c70c361a38d655cca82ea3b280ff5b6027 Reviewed-on: https://chromium-review.googlesource.com/749041 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#513835} [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/aes_decryptor_unittest.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/cdm_adapter.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/cdm_adapter.h [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/cdm_auxiliary_helper.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/cdm_auxiliary_helper.h [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/cdm_file_io.h [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/mock_helpers.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/mock_helpers.h [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/cdm/ppapi/ppapi_cdm_adapter.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/mojo/services/mojo_cdm_file_io.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/mojo/services/mojo_cdm_file_io.h [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/mojo/services/mojo_cdm_file_io_unittest.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/mojo/services/mojo_cdm_helper.cc [modify] https://crrev.com/83a6f4d54685ab63c586b6f14c8e224778493e6b/media/mojo/services/mojo_cdm_helper.h
,
Nov 3 2017
I migrated everything except for Plugin.AvailabilityStatus.WidevineCdm which needs to be done when we migrate key system support query to use a mojo service. See issue 764143 . With that, I'll update issue 764143 and mark this as fixed.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d183279ddb5463b560bd801938eb66439c825cb4 commit d183279ddb5463b560bd801938eb66439c825cb4 Author: Xiaohan Wang <xhwang@chromium.org> Date: Fri Nov 17 06:16:32 2017 media:: Move FileReadCB to MojoCdmFileIO::Delegate This is a clean up CL so that we can avoid passing one additional callback into MojoCdmFileIO. BUG= 721876 TEST=No functionality change Change-Id: Ifa3b071a5a95437f87b50f888bce72bc51ad3fd9 Reviewed-on: https://chromium-review.googlesource.com/770318 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#517324} [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/cdm/cdm_adapter.cc [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/cdm/cdm_auxiliary_helper.cc [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/cdm/cdm_auxiliary_helper.h [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/cdm/mock_helpers.cc [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/cdm/mock_helpers.h [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/mojo/services/mojo_cdm_file_io.cc [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/mojo/services/mojo_cdm_file_io.h [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/mojo/services/mojo_cdm_file_io_unittest.cc [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/mojo/services/mojo_cdm_helper.cc [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/mojo/services/mojo_cdm_helper.h [modify] https://crrev.com/d183279ddb5463b560bd801938eb66439c825cb4/media/mojo/services/mojo_cdm_helper_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by xhw...@chromium.org
, Oct 10 2017Status: Started (was: Assigned)
Here's the list of UMAs that we need to migrate/support using mojo CDM: <histogram name="Media.EME.CdmFileIO.FileSizeKBOnError" units="KB"> <histogram name="Media.EME.CdmFileIO.FileSizeKBOnFirstRead" units="KB"> <histogram name="Media.EME.CdmInterfaceVersion"> <histogram name="Media.EME.OutputProtection" enum="MediaOutputProtectionStatus"> <histogram name="Media.EME.Widevine.SystemCode" units="system code"> <histogram name="Plugin.AvailabilityStatus.WidevineCdm" enum="PluginAvailabilityStatus"> <histogram_suffixes name="PpapiPluginName" separator="_"> <suffix name="libwidevinecdmadapter.so" label="Widevine CDM on Linux or Cros"/> <suffix name="widevinecdmadapter.dll" label="Widevine CDM on Windows"/> <suffix name="widevinecdmadapter.plugin" label="Widevine CDM on Mac"/> <affected-histogram name="Plugin.PpapiBrokerLoadErrorCode"/> <affected-histogram name="Plugin.PpapiBrokerLoadResult"/> <affected-histogram name="Plugin.PpapiBrokerLoadTime"/> <affected-histogram name="Plugin.PpapiPluginLoadErrorCode"/> <affected-histogram name="Plugin.PpapiPluginLoadResult"/> <affected-histogram name="Plugin.PpapiPluginLoadTime"/> </histogram_suffixes>