New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721836 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug

Blocked on:
issue 718513


Previous locations:
gerrit:6203


Sign in to add a comment

Gerrit no longer sends the initial publish email with chromium

Project Member Reported by danakj@chromium.org, May 12 2017

Issue description

It's great that it is no longer sent as soon as I upload something, and I don't cause 100 cc'd emailed. However now the initial publish is never sent asking for a review from the people added as reviewers at the time of upload.
 

Comment 1 by aga...@chromium.org, May 12 2017

Project: chromium
Moved issue gerrit:6203 to now be  issue chromium:721836 .

Comment 2 by aga...@chromium.org, May 12 2017

Blockedon: 718513
Components: Infra>SDK
Labels: -Priority-3 Milestone-Launch Proj-Gerrit-Migration Priority-2
Owner: aga...@chromium.org
Status: Assigned (was: New)
Yeah so the problem here is that if your workflow is
1) git cl upload -r foo
2) go to web interface
3) click "Reply" and type+send a message
then the resulting message is *just* your message. It doesn't contain the "X wants Y to review a change" text, and it doesn't contain the commit description or other useful metadata.

This will be resolved by having git-cl-upload use the WIP workflow, which is coming very soon.

Comment 3 by aga...@chromium.org, Jun 21 2017

Cc: ishell@chromium.org machenb...@chromium.org tandrii@chromium.org aga...@chromium.org
 Issue 718513  has been merged into this issue.

Comment 4 by aga...@chromium.org, Jun 26 2017

 Issue gerrit:6562  has been merged into this issue.

Comment 5 by aga...@chromium.org, Jun 27 2017

Cc: gab@chromium.org
 Issue 736946  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/70f4e24d1524e7556ac7328e62daf4ab42bb8d06

commit 70f4e24d1524e7556ac7328e62daf4ab42bb8d06
Author: Aaron Gable <agable@chromium.org>
Date: Tue Jun 27 20:28:08 2017

git-cl: upload changes in WIP unless --send-mail

Work-In-Progress is a new change flag that can be set on
Gerrit changes. While a change is in WIP mode, certain things
are different:
* It doesn't send emails except to the change owner
* The "Reply" button becomes "Start Review"
* When a change is moved out of WIP, it sends a special
  "ready for review" message to any new reviewers
This is much more similar to the Rietveld model, where users
would "Publish" their changes for the reviewers to look at.

Bug:  721836 
Change-Id: I3b9697e311fa176cb679ecefbfead9bb32b6afaf
Reviewed-on: https://chromium-review.googlesource.com/549015
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/70f4e24d1524e7556ac7328e62daf4ab42bb8d06/tests/git_cl_test.py
[modify] https://crrev.com/70f4e24d1524e7556ac7328e62daf4ab42bb8d06/git_cl.py

Comment 7 by aga...@chromium.org, Jun 27 2017

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/afd527777845559fe305399a362702f2e2d7e4ab

commit afd527777845559fe305399a362702f2e2d7e4ab
Author: Aaron Gable <agable@chromium.org>
Date: Tue Jun 27 23:46:07 2017

git-cl-upload: make it possible to exit WIP mode

The previous CL forgot that the lack of '%wip' doesn't
mark a change ready-to-review, you have to explicitly pass
'%ready' in the refspec to do that.

TBR=tandrii@chromium.org

Bug:  721836 
Change-Id: Iea82222d64edf1b73fefa9bca3feec4188e35ab3
Reviewed-on: https://chromium-review.googlesource.com/551005
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/afd527777845559fe305399a362702f2e2d7e4ab/tests/git_cl_test.py
[modify] https://crrev.com/afd527777845559fe305399a362702f2e2d7e4ab/git_cl.py

Maybe I missed something, but how do I end WIP state? Can only CL owners end WIP state? I have an auto-roller uploading and I didn't find any button:
https://screenshot.googleplex.com/TRAwNWrxfWQ.png

I assume I need to let the auto-rollers upload with --send-mail, but I removed that once, as I don't want to get the initial spam either. I'd prefer getting only an email with the message when the CL lands.
Maybe using --use-commit-queue on upload, but not using --send-mail should lead to an immediate error or at least warning on upload as the CQ will reject landing it anyways.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/81d3ac833632b50e51aaf0d9b66d151094548a94

commit 81d3ac833632b50e51aaf0d9b66d151094548a94
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Jun 28 14:33:15 2017

V8: Don't upload auto-rolls in WIP state.

Bug:  721836 
Change-Id: I7f9e23b318949dc50791f33efa26782184495fb1
Reviewed-on: https://chromium-review.googlesource.com/551960
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/81d3ac833632b50e51aaf0d9b66d151094548a94/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/roll.json
[modify] https://crrev.com/81d3ac833632b50e51aaf0d9b66d151094548a94/scripts/slave/recipes/v8/auto_roll_v8_deps.py

 Issue 737782  has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/844cf2963be2f1e178382cfaf2906a7215746368

commit 844cf2963be2f1e178382cfaf2906a7215746368
Author: Aaron Gable <agable@chromium.org>
Date: Wed Jun 28 23:56:31 2017

git-cl: only set WIP on first upload

It seems like some folks are confused by additional patchsets
after the first putting the change back into WIP mode. This
confusion is honestly understandable. Maybe we try only setting
it on the very first upload, and just controlling the notify
parameter for future patchsets.

Bug:  721836 ,  737675 
Change-Id: If56e5c71e0c6b3b46c2e30ac0b6d80b878218181
Reviewed-on: https://chromium-review.googlesource.com/552779
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: smut <smut@google.com>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/844cf2963be2f1e178382cfaf2906a7215746368/tests/git_cl_test.py
[modify] https://crrev.com/844cf2963be2f1e178382cfaf2906a7215746368/git_cl.py

Cc: iannucci@chromium.org
FYI iannucci: The recipe roller suffers from this too:
https://chromium-review.googlesource.com/c/556054/

Uploads in WIP state and then can land.
Filed http://crbug.com/738145 for this.

Sign in to add a comment