Gerrit no longer sends the initial publish email with chromium |
|||||
Issue descriptionIt's great that it is no longer sent as soon as I upload something, and I don't cause 100 cc'd emailed. However now the initial publish is never sent asking for a review from the people added as reviewers at the time of upload.
,
May 12 2017
Yeah so the problem here is that if your workflow is 1) git cl upload -r foo 2) go to web interface 3) click "Reply" and type+send a message then the resulting message is *just* your message. It doesn't contain the "X wants Y to review a change" text, and it doesn't contain the commit description or other useful metadata. This will be resolved by having git-cl-upload use the WIP workflow, which is coming very soon.
,
Jun 21 2017
Issue 718513 has been merged into this issue.
,
Jun 26 2017
Issue gerrit:6562 has been merged into this issue.
,
Jun 27 2017
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/70f4e24d1524e7556ac7328e62daf4ab42bb8d06 commit 70f4e24d1524e7556ac7328e62daf4ab42bb8d06 Author: Aaron Gable <agable@chromium.org> Date: Tue Jun 27 20:28:08 2017 git-cl: upload changes in WIP unless --send-mail Work-In-Progress is a new change flag that can be set on Gerrit changes. While a change is in WIP mode, certain things are different: * It doesn't send emails except to the change owner * The "Reply" button becomes "Start Review" * When a change is moved out of WIP, it sends a special "ready for review" message to any new reviewers This is much more similar to the Rietveld model, where users would "Publish" their changes for the reviewers to look at. Bug: 721836 Change-Id: I3b9697e311fa176cb679ecefbfead9bb32b6afaf Reviewed-on: https://chromium-review.googlesource.com/549015 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/70f4e24d1524e7556ac7328e62daf4ab42bb8d06/tests/git_cl_test.py [modify] https://crrev.com/70f4e24d1524e7556ac7328e62daf4ab42bb8d06/git_cl.py
,
Jun 27 2017
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/afd527777845559fe305399a362702f2e2d7e4ab commit afd527777845559fe305399a362702f2e2d7e4ab Author: Aaron Gable <agable@chromium.org> Date: Tue Jun 27 23:46:07 2017 git-cl-upload: make it possible to exit WIP mode The previous CL forgot that the lack of '%wip' doesn't mark a change ready-to-review, you have to explicitly pass '%ready' in the refspec to do that. TBR=tandrii@chromium.org Bug: 721836 Change-Id: Iea82222d64edf1b73fefa9bca3feec4188e35ab3 Reviewed-on: https://chromium-review.googlesource.com/551005 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/afd527777845559fe305399a362702f2e2d7e4ab/tests/git_cl_test.py [modify] https://crrev.com/afd527777845559fe305399a362702f2e2d7e4ab/git_cl.py
,
Jun 28 2017
Maybe I missed something, but how do I end WIP state? Can only CL owners end WIP state? I have an auto-roller uploading and I didn't find any button: https://screenshot.googleplex.com/TRAwNWrxfWQ.png I assume I need to let the auto-rollers upload with --send-mail, but I removed that once, as I don't want to get the initial spam either. I'd prefer getting only an email with the message when the CL lands.
,
Jun 28 2017
Maybe using --use-commit-queue on upload, but not using --send-mail should lead to an immediate error or at least warning on upload as the CQ will reject landing it anyways.
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/81d3ac833632b50e51aaf0d9b66d151094548a94 commit 81d3ac833632b50e51aaf0d9b66d151094548a94 Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Jun 28 14:33:15 2017 V8: Don't upload auto-rolls in WIP state. Bug: 721836 Change-Id: I7f9e23b318949dc50791f33efa26782184495fb1 Reviewed-on: https://chromium-review.googlesource.com/551960 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/81d3ac833632b50e51aaf0d9b66d151094548a94/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/roll.json [modify] https://crrev.com/81d3ac833632b50e51aaf0d9b66d151094548a94/scripts/slave/recipes/v8/auto_roll_v8_deps.py
,
Jun 28 2017
Issue 737782 has been merged into this issue.
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/844cf2963be2f1e178382cfaf2906a7215746368 commit 844cf2963be2f1e178382cfaf2906a7215746368 Author: Aaron Gable <agable@chromium.org> Date: Wed Jun 28 23:56:31 2017 git-cl: only set WIP on first upload It seems like some folks are confused by additional patchsets after the first putting the change back into WIP mode. This confusion is honestly understandable. Maybe we try only setting it on the very first upload, and just controlling the notify parameter for future patchsets. Bug: 721836 , 737675 Change-Id: If56e5c71e0c6b3b46c2e30ac0b6d80b878218181 Reviewed-on: https://chromium-review.googlesource.com/552779 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: smut <smut@google.com> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/844cf2963be2f1e178382cfaf2906a7215746368/tests/git_cl_test.py [modify] https://crrev.com/844cf2963be2f1e178382cfaf2906a7215746368/git_cl.py
,
Jun 29 2017
FYI iannucci: The recipe roller suffers from this too: https://chromium-review.googlesource.com/c/556054/ Uploads in WIP state and then can land.
,
Jun 29 2017
Filed http://crbug.com/738145 for this. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by aga...@chromium.org
, May 12 2017