New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721820 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

AiS: Last character bold

Project Member Reported by emilyschechter@chromium.org, May 12 2017

Issue description

Strange boldness happening on MacOS.

https://screenshot.googleplex.com/2m5zn5LuiYH
 
Labels: -OS-Mac OS-All
Owner: jdonnelly@chromium.org
Status: Assigned (was: Untriaged)
I see this on Linux, too. I think it's something to do with how we're interpreting the answer responses.
Labels: Hotlist-Polish
It's probably this code:
    // Verbatim results don't get suggestions and hence, answers.
    // Scan previous matches if the last answer-bearing suggestion matches
    // verbatim, and if so, copy over answer contents.
    ...
https://cs.chromium.org/chromium/src/components/omnibox/browser/search_provider.cc?l=975-992

which means for verbatim suggestions with answers, you're displaying the answer as it appeared the last time it was received.  Its bolding should be recalculated.

Summary: AiS: Last character bold (was: AiS: Last character bold MacOS)
Labels: Hotlist-GoodFirstBug
Cc: krajshree@chromium.org viswa.karala@chromium.org
 Issue 820697  has been merged into this issue.
Cc: jdonnelly@chromium.org
Owner: ----
Status: Available (was: Assigned)
Cc: k...@chromium.org
 Issue 829810  has been merged into this issue.
Owner: k...@chromium.org
Status: Assigned (was: Available)
 Issue 834798  has been merged into this issue.
Owner: jdonnelly@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c51f302123e4c46042fb2c2e0a244a28b87bcc

commit 65c51f302123e4c46042fb2c2e0a244a28b87bcc
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Thu Jun 14 13:35:38 2018

[omnibox] Fix for last character of an answer could be incorrectly bold.

The first line of answers contains text and bolding that's calculated
server-side. That calculation is nearly identical to what we do Chrome-
side for non-answers. This change makes it so that we use the Chrome
calculation to avoid the problem were an old-but-still-matching answer
could be copied to the what-you-typed match and have the wrong bolding.

Because the first line of answers can have some additional text besides
the query, that additional text is added in a separate step.

Because we're no longer using the server-provided bolding, which used
HTML <b> tags, we no longer need the parsing of those tags that we were
previously using.

Finally, since there was code moving around in omnibox_text_view.cc
anyway, I made some simplifications based on the fact that this class
only ever has one render text.

Bug:  721820 
Change-Id: I816c55cf9ff680dd922a18ef4cb9301543e1de25
Reviewed-on: https://chromium-review.googlesource.com/1070506
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567248}
[modify] https://crrev.com/65c51f302123e4c46042fb2c2e0a244a28b87bcc/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/65c51f302123e4c46042fb2c2e0a244a28b87bcc/chrome/browser/ui/views/omnibox/omnibox_text_view.cc
[modify] https://crrev.com/65c51f302123e4c46042fb2c2e0a244a28b87bcc/chrome/browser/ui/views/omnibox/omnibox_text_view.h

Status: Fixed (was: Started)

Sign in to add a comment