New issue
Advanced search Search tips

Issue 721814 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

wpt-importer is now failing due to new idlharness test with missing results.

Project Member Reported by qyears...@chromium.org, May 12 2017

Issue description

Latest jobs:
https://chromium-review.googlesource.com/c/503669/
https://chromium-review.googlesource.com/c/504587/

In these imports, wpt-update-expectations tried to add a line like:
crbug.com/626703 external/wpt/web-nfc/idlharness.https.html [  ]

This happened because this idlharness.https.html test was not rebaselined. It may have been interpreted as a pixel test rather tha

In general, in cases similar to this, it's better to just skip the test and move on in order to prevent blocking import.
 
Status: Fixed (was: Started)
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44c2aec5bbd487a98728635f32e8f3c3d6935768

commit 44c2aec5bbd487a98728635f32e8f3c3d6935768
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Tue Aug 22 03:36:15 2017

LayoutTests: Disabling WebCryptoAPI tests imported for wpt.

These tests are flaky on Mac / Windows and are failing everywhere.

BUG=655458, 721814 , 757698 ,709227
TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: Ia0ae3d6ee71751bf667c110e732c557309c21737
Reviewed-on: https://chromium-review.googlesource.com/624770
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496200}
[modify] https://crrev.com/44c2aec5bbd487a98728635f32e8f3c3d6935768/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48bdfc57f7a71076ae35788dd18b27d3c8439a9f

commit 48bdfc57f7a71076ae35788dd18b27d3c8439a9f
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Tue Aug 22 08:32:46 2017

LayoutTests: Disable WebCryptoAPI missed from last CL.

XXX.worker.html verse XXX.https.html

Failures -> https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/61159

BUG=655458, 721814 , 757698 ,709227
TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: I3cf8864d8a5c8af379322b25298e0e7ebdc6b356
Reviewed-on: https://chromium-review.googlesource.com/625638
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496251}
[modify] https://crrev.com/48bdfc57f7a71076ae35788dd18b27d3c8439a9f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a581405cdb71ba301a6694c03c90ba730541816d

commit a581405cdb71ba301a6694c03c90ba730541816d
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Aug 22 10:31:40 2017

Fix incorrect paths in WebCrpytoAPI TestExpectations

BUG=655458, 721814 , 757698 ,709227
TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: I05c9db91a8e104d871c1f82aec6129066518259a
Reviewed-on: https://chromium-review.googlesource.com/625517
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496271}
[modify] https://crrev.com/a581405cdb71ba301a6694c03c90ba730541816d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e0702f4f6561a8fd1eec1684c8cda906576091

commit b9e0702f4f6561a8fd1eec1684c8cda906576091
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Aug 22 11:20:48 2017

Revert "Fix incorrect paths in WebCrpytoAPI TestExpectations"

This reverts commit a581405cdb71ba301a6694c03c90ba730541816d.

Reason for revert: Might have accidentally added/removed tests, and we want to Skip some of these, not Pass/Failure.

Original change's description:
> Fix incorrect paths in WebCrpytoAPI TestExpectations
> 
> BUG=655458, 721814 , 757698 ,709227
> TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
> NOTRY=true
> 
> Change-Id: I05c9db91a8e104d871c1f82aec6129066518259a
> Reviewed-on: https://chromium-review.googlesource.com/625517
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496271}

TBR=hbos@chromium.org

Change-Id: Id3c86fc509f644fdc3bc6a196650c1c3cd157fa9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 655458,  721814 ,  757698 , 709227
Reviewed-on: https://chromium-review.googlesource.com/625996
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496279}
[modify] https://crrev.com/b9e0702f4f6561a8fd1eec1684c8cda906576091/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment