Lots of warnings in the console of the ZIP unpacker app |
|||||||||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) Open a ZIP archive in Chrome OS. What happens instead? A lot of warnings in the background page console of the ZIP unpacker app: * "IsDirectory specified, but not requested." * "Name specified, but not requested." Note that when running a target_os="chromeos" on Linux, all these messages become spamming the stderr output of Chrome. fukino@: Assigning to you for triaging, as per the OWNERS file.
,
May 15 2017
,
May 15 2017
Tomasz, do you have any ideas about when these can be warned? According to the comments in verifyMetadata (file_system_provider_custom_bindings.js), they are not treated as errors for backward compatibility. https://codesearch.chromium.org/chromium/src/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js?type=cs&q=%22IsDirectory+specified,+but+not+requested.%22+package:%5Echromium$&l=62 To remove these warnings, should we update ZIP unpacker to follow the latest requirements?
,
May 15 2017
Yes, we should update ZIP unpacker so it doesn't return information which is not requested, as it will be discarded anyway.
,
Oct 24 2017
,
Feb 6 2018
,
Feb 6 2018
,
Feb 22 2018
,
Feb 28 2018
,
Oct 31
Anand - still relevant?
,
Nov 1
Yes, very. Doesn't cause any problems, but does cause a lot of annoying log spam.
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c4cb79700b5d495033d8b8ccf9b637743f41fd9 commit 9c4cb79700b5d495033d8b8ccf9b637743f41fd9 Author: Anand K. Mistry <amistry@chromium.org> Date: Fri Nov 02 05:56:48 2018 Filter out metadata fields that are not requested in zip archiver Metadata requests in the chrome.fileSystemProvider API declare what metadata fields they are requesting (i.e. size, modifiction time, etc). Fields that are provided but not requested will be logged as warnings. BUG= 721790 Change-Id: Ia2c1c1b39f72048be654069557cfc951c5cfc325 Reviewed-on: https://chromium-review.googlesource.com/c/1313989 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604852} [modify] https://crrev.com/9c4cb79700b5d495033d8b8ccf9b637743f41fd9/chrome/browser/resources/chromeos/zip_archiver/js/volume.js
,
Nov 4
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by fukino@chromium.org
, May 15 2017