ModuleScriptFetchRequest should support an empty parser state |
|||||
Issue descriptionThe fetch spec[1] says... "A request has associated parser metadata which is the empty string, "parser-inserted", or "not-parser-inserted". Unless otherwise stated, it is the empty string." , but current ModuleScriptFetchRequest cannot handle the empty string [2]. To support it, we could add a new enum value into ParserDisposition or make the request's |parser_state_| WTF::Optional. [1] https://fetch.spec.whatwg.org/#concept-request-parser-metadata [2] https://chromium.googlesource.com/chromium/src/+/a66d812aa78debb856c1938f439e98feabeaeada/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h#70
,
May 12 2017
Adding a new enum value sounds like a better option. +domenic
,
May 12 2017
My guess is that the empty string only comes up for API-constructed requests (via new Request()). It's not clear to me why "not parser-inserted" isn't a good fit for that. Maybe Mike West or Anne can help us understand.
,
May 12 2017
https://github.com/w3c/webappsec-csp/issues/70 is the feature for which it was added. The empty string seems to be used for most requests as this member is only set for <script> requests by HTML. And in https://w3c.github.io/webappsec-csp/ it's only looked at for scripts (though that encompasses more than <script>). I'm not intimately familiar with the entire setup though. Mike should know.
,
May 14 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nhiroki@chromium.org
, May 12 2017