Issue metadata
Sign in to add a comment
|
The Separator is not centered between Chip and Omnibox text |
||||||||||||||||||||||||
Issue descriptionChrome Version: Stable 58 and Canary 60 OS: Windows What steps will reproduce the problem? (1) go to https://www.google.com (2) take a look at the separator between Chip and Omnibox text What is the expected result? The separator should be 1px to the left to be nicely centered. What happens instead? The separator is 1px to far right and it is not centered. Please use labels and text to provide additional information. A screenshot is attached. Thanks.
,
May 12 2017
+shrike@. He was able to center it nicely on MacOS. Maybe he has an idea? :-)
,
May 12 2017
I can't provide much help on the Views side with this. I also wonder if, as pkasting@ suggests, the spacing may vary as the letters change.
,
May 16 2017
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/959d42beb82698415e47bfde4fc791e56aa422ed commit 959d42beb82698415e47bfde4fc791e56aa422ed Author: estade <estade@chromium.org> Date: Tue May 16 17:57:12 2017 Adjust position of separator in location bar. The separator is positioned based on the layout of the label. Previously we forgot to account for the width of the separator when laying out the label, so in effect the label was 1dip too wide and the separator was 1dip too far to the right. This only affects DSFs <2. BUG= 721741 Review-Url: https://codereview.chromium.org/2883843004 Cr-Commit-Position: refs/heads/master@{#472153} [modify] https://crrev.com/959d42beb82698415e47bfde4fc791e56aa422ed/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/959d42beb82698415e47bfde4fc791e56aa422ed/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
,
May 16 2017
,
Sep 14 2017
Hello estade@. I noticed, that the separator is still not centered between label and text. It is still looking 1px too far to the right. I am using a Device with Windows 7 and Chrome 61. Any chance to take a look at this issue again? Thank you in advance.
,
Sep 14 2017
Hi mehmet - can you attach a screenshot?
,
Sep 14 2017
I am using the Windows 7 device at my work. I am at home now - only a Mac here :-) So I can grab the screenshot tomorrow and attach it here.
,
Sep 14 2017
Additional to my last comment: It is looking the same like in my screenshot "actual" in comment#0
,
Sep 14 2017
Attached is how my Win 10 box at home looks. Definitely seems a bit off.
,
Sep 14 2017
Thank you pkasting@ for the screenshot. Please find enclosed a screencast how fine the separator is centered on macOS and the right edge of the hover-background line up precisely with the separator. It would be nice to have this on Windows too. Thank you very much in advance.
,
Sep 14 2017
please file a new bug. This is a regression and I suspect it is a result of crrev.com/bf7e0532e34476062226eab6
,
Sep 14 2017
Done: Issue 765382 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, May 12 2017Status: Assigned (was: Untriaged)