New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

The Separator is not centered between Chip and Omnibox text

Project Member Reported by meh...@chromium.org, May 12 2017

Issue description

Chrome Version: Stable 58 and Canary 60
OS: Windows

What steps will reproduce the problem?
(1) go to https://www.google.com
(2) take a look at the separator between Chip and Omnibox text

What is the expected result?
The separator should be 1px to the left to be nicely centered.

What happens instead?
The separator is 1px to far right and it is not centered.


Please use labels and text to provide additional information.
A screenshot is attached.

Thanks.
 
screenshot_actual_vs_expected.png
42.6 KB View Download
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
I think there's some complications due to spacing included in the font/textfields themselves; that is, we may see different results with different letters in these positions.

That said, in my own testing this looks less centered than I thought it used to be.  I tried triggering keyword search mode, which gives more freedom to force the characters on either side, and it looked off no matter what I did.

Evan, mind taking a look?  I would assume this is cross-platform.

Comment 2 by meh...@chromium.org, May 12 2017

Cc: shrike@chromium.org
+shrike@. He was able to center it nicely on MacOS. Maybe he has an idea? :-)

Comment 3 by shrike@chromium.org, May 12 2017

I can't provide much help on the Views side with this. I also wonder if, as pkasting@ suggests, the spacing may vary as the letters change.

Comment 4 by est...@chromium.org, May 16 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/959d42beb82698415e47bfde4fc791e56aa422ed

commit 959d42beb82698415e47bfde4fc791e56aa422ed
Author: estade <estade@chromium.org>
Date: Tue May 16 17:57:12 2017

Adjust position of separator in location bar.

The separator is positioned based on the layout of the label. Previously
we forgot to account for the width of the separator when laying out the
label, so in effect the label was 1dip too wide and the separator was
1dip too far to the right.

This only affects DSFs <2.

BUG= 721741 

Review-Url: https://codereview.chromium.org/2883843004
Cr-Commit-Position: refs/heads/master@{#472153}

[modify] https://crrev.com/959d42beb82698415e47bfde4fc791e56aa422ed/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/959d42beb82698415e47bfde4fc791e56aa422ed/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Comment 6 by est...@chromium.org, May 16 2017

Status: Fixed (was: Started)

Comment 7 by meh...@chromium.org, Sep 14 2017

Hello estade@.

I noticed, that the separator is still not centered between label and text. It is still looking 1px too far to the right. I am using a Device with Windows 7 and Chrome 61. Any chance to take a look at this issue again? Thank you in advance.

Comment 8 by shrike@chromium.org, Sep 14 2017

Status: Assigned (was: Fixed)
Hi mehmet - can you attach a screenshot?

Comment 9 by meh...@chromium.org, Sep 14 2017

I am using the Windows 7 device at my work. I am at home now - only a Mac here :-) So I can grab the screenshot tomorrow and attach it here.
Additional to my last comment: It is looking the same like in my screenshot "actual" in comment#0
Attached is how my Win 10 box at home looks.  Definitely seems a bit off.
Untitled.png
939 bytes View Download
Thank you pkasting@ for the screenshot.

Please find enclosed a screencast how fine the separator is centered on macOS and the right edge of the hover-background line up precisely with the separator.

It would be nice to have this on Windows too. Thank you very much in advance.
screencast_macOS.mov
874 KB Download
Cc: spqc...@chromium.org
Status: Fixed (was: Assigned)
please file a new bug. This is a regression and I suspect it is a result of crrev.com/bf7e0532e34476062226eab6
Done:  Issue 765382 

Sign in to add a comment