New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721723 link

Starred by 3 users
Status: Verified
Owner:
steve...@chromium.org
Closed: May 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ scottchen@chromium.org
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Two focuses are seen on 'Close' icon on tabbing in 'Manage other users' Page

Project Member Reported by mmanchala@chromium.org, May 12 2017 
Chrome Version: 60.0.3096.0/9542.0.0 dev-channel Daisy,Candy and Minnie

OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Go to chrome://md-settings/accounts page
(2)In 'Manage Other users' page -> Enable  'Restrict sign-in to the following users' option so that 'Add person' option is enabled
(3)Now click on 'Add person' -> Enter any email id
(4)Now Click on 'Tab' Button until focus reaches on 'Close' Icon and observe two Focuses (Please refer Video and screenshot)

Expected: Only one Focus should be seen on 'Close' icon
Actual: Instead Two focuses are seen on 'Close' icon 

This is Regression issue as same is working fine in 59.0.3-71.49/9460.36.0 dev-channel Candy

@stevenjb : Please confirm the Issue
Actual_Focus.webm
718 KB View Download
Actual_Focus.jpg
79.4 KB View Download
Expected_Focus.jpg
82.9 KB View Download
Expected_Focus.webm
940 KB View Download

Comment 1 by steve...@chromium.org, May 16 2017

Cc: scottchen@chromium.org dschuyler@chromium.org
Labels: -Pri-1 Pri-2
Scott, is this the same artifact that you were looking to fix here:

https://codereview.chromium.org/2848973003/diff/380001/chrome/browser/resources/settings/people_page/user_list.html

(Where are we on that anyway?)

Comment 2 by dbeam@chromium.org, May 18 2017

Labels: Hotlist-MD-Settings-PeopleCrOS

Comment 3 by steve...@chromium.org, May 23 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e5531d557726181f7004a6ad5fd4e7502787a9

commit f0e5531d557726181f7004a6ad5fd4e7502787a9
Author: stevenjb <stevenjb@chromium.org>
Date: Wed May 24 06:06:30 2017

WebUI: Only highlight scrollable divs

This CL:
* Modifies the rule in shared_style_css for [scrollable] :focus to
  only include direct descendents of iron-list and to exclude
  .no-outline.
* Removes [scrollable] .no-outline rule in settings_shared_css
  intended to do the same thing (but was not specific enough).
* Removes some unused includes of CrScrollableBehavior.

BUG= 721723 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2900173004
Cr-Commit-Position: refs/heads/master@{#474180}

[modify] https://crrev.com/f0e5531d557726181f7004a6ad5fd4e7502787a9/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/f0e5531d557726181f7004a6ad5fd4e7502787a9/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
[modify] https://crrev.com/f0e5531d557726181f7004a6ad5fd4e7502787a9/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp
[modify] https://crrev.com/f0e5531d557726181f7004a6ad5fd4e7502787a9/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/f0e5531d557726181f7004a6ad5fd4e7502787a9/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/f0e5531d557726181f7004a6ad5fd4e7502787a9/ui/webui/resources/cr_elements/shared_style_css.html

Comment 5 by steve...@chromium.org, May 24 2017

Status: Fixed (was: Started)

Comment 6 by abod...@chromium.org, Jun 15 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment