New issue
Advanced search Search tips

Issue 721716 link

Starred by 1 user
Status: Fixed
Owner:
kolos@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Password Manager] Send a request to the store on click at a password field if needed

Project Member Reported by kolos@chromium.org, May 12 2017 
It is possible that the password manager didn't detect a password field (e.g. the field was created dynamically, but  PasswordAutofillAgent::OnDynamicFormsSeen wasn't called). If it happens, then do send a request to the store. When the request is processed, the user will see suggestions in the password field.

Possible implementation:
In PasswordAutofillAgent::FindPasswordInfoForElement, check whether |sent_request_to_store| is true (if the focused element is a password field). If not, call SendPasswordForm.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9436e7c73362bf570dac89cf60c06e5a9a858e87

commit 9436e7c73362bf570dac89cf60c06e5a9a858e87
Author: kolos <kolos@chromium.org>
Date: Thu May 18 11:36:22 2017

[Password Manager] Send a request to the store if user clicks on a password field that we didn't detect

For some reason, the password manager might miss that there is a password field on the page (e.g. dynamic form, a field that changed the type from 'text' to 'password'). If a user clicks on the password field, but there was no request to the password store, then fetch saved credentials on click. When the response is received, the manual fallback for filling will be available.

BUG= 721716 

Review-Url: https://codereview.chromium.org/2881033003
Cr-Commit-Position: refs/heads/master@{#472767}

[modify] https://crrev.com/9436e7c73362bf570dac89cf60c06e5a9a858e87/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/9436e7c73362bf570dac89cf60c06e5a9a858e87/components/autofill/content/renderer/password_autofill_agent.cc

Comment 2 by kolos@chromium.org, May 18 2017 

Keep the issue open since it needed to check whether the dropdown list appears when the request is received. Otherwise, a user should click on the field once more to the results.

Comment 3 by vabr@chromium.org, Jun 8 2017

Labels: Hotlist-Polish

Comment 4 by kolos@chromium.org, Jan 26 2018

Owner: kolos@chromium.org
Status: Fixed (was: Available)
Didn't receive any complaints like #2.
►

Sign in to add a comment