devtools_http_handler.cc incorrectly logging ERROR line during Android tests |
|||||||||
Issue descriptionAll Android tests executing are seeing this ERROR line in the logs, no matter if the test is successful or failing. ERROR:devtools_http_handler.cc(225)] Cannot start http server for devtools. Stop devtools. It's constantly confusing developers trying to debug failures. Please change the warning level or preferably make it only appear when it makes sense. Examples: Successful build: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/42421 Failing build: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/42424 CCing vkuzkokov@chromium.org according to git blame. Similar to bug 721713 .
,
May 15 2017
Eugene, could you please take a look?
,
May 19 2017
For some reason bug was not updated when https://codereview.chromium.org/2877413003/ landed. We need that error message so we added a message to the test that informs that the error is expected.
,
May 20 2017
The referenced CL only changes a single test in content_unittests. The main problem in this bug is that for just about every single test in content_browsertests this error log line shows up. There must be a better way to either change the logging level (how can it have to be error level when it doesn't affect the test?). Please fix this properly, it is wasting a lot of time for engineers trying to debug tests, and it undermines the trust in all logging.
,
May 21 2017
Note that logs show this error message appears only once [1], exactly in the test changed in the patch. Please double check properly. [1] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests__dbg_%2F42424%2F%2B%2Frecipes%2Fsteps%2Fcontent_unittests_on_Android%2F0%2Fstdout
,
May 21 2017
So, let me explain. There's a difference between the test that was fixed in https://codereview.chromium.org/2877413003/ and the one I'm talking about. If you read my comment #4 carefully you'll see that I clearly points out the problem is in content_browsertests, not content_unittests (which is the only thing the test fixes). As an example: A recent build of Android Tests: https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/181833 shows 1628 occurrences of the string [ERROR:devtools_http_handler.cc(226)] Cannot start http server for devtools. Stop devtools. That's the whole problem I was trying to describe with this bug. It shows up for every single test run and is not an error!
,
May 22 2017
Sorry, my bad, I was sure you are talking about unit tests. We'll take a look. Example stdout: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests__dbg_%2F42421%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests_on_Android%2F0%2Fstdout
,
May 31 2017
Bug 727725 is another example of a sheriff being confused by this error. I hope it can be fixed.
,
Jul 31 2017
It again caused a failure on in the sheriff dashboard. Adding the sheriff label so that further sheriffs - understand the cause for failures and - can ping on this bug. Is there any update on this bug?
,
Aug 2 2017
,
Aug 14 2017
I am yet another sheriff confused by this log message. Please fix.
,
Jan 11 2018
Triaging old issues |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vkuzkokov@chromium.org
, May 15 2017