Move common/camera_metadata.cc to android/ and build it as a library to be shared between camera HALs.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4b9bc521daa515638b8d7bc81c9681b15de07829 commit 4b9bc521daa515638b8d7bc81c9681b15de07829 Author: Daniel Hung-yu Wu <hywu@chromium.org> Date: Wed May 24 09:09:07 2017 arc-camera3-libcamera_client: add ebuild for libcamera_client BUG= chromium:721671 TEST='emerge-<board> arc-camera3-libcamera_client' CQ-DEPEND=CL:511924 Change-Id: Ifb138a80fcbae3e191a7245188acc7c84d94a8ca Reviewed-on: https://chromium-review.googlesource.com/512322 Commit-Ready: Hung-yu Wu <hywu@chromium.org> Tested-by: Hung-yu Wu <hywu@chromium.org> Reviewed-by: Heng-ruey Hsu <henryhsu@google.com> [add] https://crrev.com/4b9bc521daa515638b8d7bc81c9681b15de07829/media-libs/arc-camera3-libcamera_client/arc-camera3-libcamera_client-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/2bd8130948d3965969ed06fbf77d62270818ddd6 commit 2bd8130948d3965969ed06fbf77d62270818ddd6 Author: Daniel Hung-yu Wu <hywu@chromium.org> Date: Wed May 24 09:06:23 2017 android: import libcamera_client from Android goog/nyc-mr1-arc branch BUG= chromium:721671 TEST='emerge-<board> arc-camera3-libcamera_client' CQ-DEPEND=CL:512322 Change-Id: I78212344b7a08558e856f89f0e068a77ba3e624e Reviewed-on: https://chromium-review.googlesource.com/511924 Commit-Ready: Hung-yu Wu <hywu@chromium.org> Tested-by: Hung-yu Wu <hywu@chromium.org> Reviewed-by: Heng-ruey Hsu <henryhsu@google.com> [add] https://crrev.com/2bd8130948d3965969ed06fbf77d62270818ddd6/android/libcamera_client/module.mk [add] https://crrev.com/2bd8130948d3965969ed06fbf77d62270818ddd6/android/libcamera_client/src/diff/camera_metadata.c.diff [modify] https://crrev.com/2bd8130948d3965969ed06fbf77d62270818ddd6/android/Makefile [add] https://crrev.com/2bd8130948d3965969ed06fbf77d62270818ddd6/android/libcamera_client/include/diff/camera_metadata.h.diff [add] https://crrev.com/2bd8130948d3965969ed06fbf77d62270818ddd6/android/libcamera_client/libcamera_client.pc.template [add] https://crrev.com/2bd8130948d3965969ed06fbf77d62270818ddd6/android/libcamera_client/include/camera/camera_metadata.h [add] https://crrev.com/2bd8130948d3965969ed06fbf77d62270818ddd6/android/libcamera_client/src/camera_metadata.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/48b3f9f623c065668827a2c7801154007ae04a7a commit 48b3f9f623c065668827a2c7801154007ae04a7a Author: Daniel Hung-yu Wu <hywu@chromium.org> Date: Fri May 26 15:14:20 2017 usb: use libcamera_client library BUG= chromium:721671 TEST='emerge-<board> arc-camera3-hal-usb' CQ-DEPEND=CL:511924,CL:512563 Change-Id: If25cda27629e6514adee2eb8e858489a14e4e73c Reviewed-on: https://chromium-review.googlesource.com/512428 Commit-Ready: Hung-yu Wu <hywu@chromium.org> Tested-by: Hung-yu Wu <hywu@chromium.org> Reviewed-by: Heng-ruey Hsu <henryhsu@google.com> [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/image_processor.h [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/capture_request.cc [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/capture_request.h [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/metadata_handler.h [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/module.mk [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/image_processor.cc [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/metadata_handler.cc [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/cached_frame.cc [delete] https://crrev.com/cd3640df33c67cd0b029a4237df18eb280bf445e/include/arc/camera_metadata.h [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/camera_hal.cc [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/camera_client.cc [delete] https://crrev.com/cd3640df33c67cd0b029a4237df18eb280bf445e/common/camera_metadata.cc [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/frame_buffer.h [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/common/module.mk [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/camera_client.h [modify] https://crrev.com/48b3f9f623c065668827a2c7801154007ae04a7a/hal/usb/cached_frame.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7cf73e95db1a3641090f4161e9af5b22da5fb9d8 commit 7cf73e95db1a3641090f4161e9af5b22da5fb9d8 Author: Daniel Hung-yu Wu <hywu@chromium.org> Date: Fri May 26 15:14:20 2017 arc-camera3-hal-usb: add dependency on libcamera_client library BUG= chromium:721671 TEST='emerge-<board> arc-camera3-hal-usb' CQ-DEPEND=CL:512322,CL:512428 Change-Id: I7a7c18ca9b7abc621355ea138b1031d8c28370e9 Reviewed-on: https://chromium-review.googlesource.com/512563 Commit-Ready: Hung-yu Wu <hywu@chromium.org> Tested-by: Hung-yu Wu <hywu@chromium.org> Reviewed-by: Heng-ruey Hsu <henryhsu@google.com> [modify] https://crrev.com/7cf73e95db1a3641090f4161e9af5b22da5fb9d8/media-libs/arc-camera3-hal-usb/arc-camera3-hal-usb-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/1e50b07a4cb05c1311688ce186d295ad4d018d59 commit 1e50b07a4cb05c1311688ce186d295ad4d018d59 Author: Shik Chen <shik@chromium.org> Date: Thu Mar 29 12:38:12 2018 libcamera_client: fix a potential compile error "no member named 'array'" We shuold use std::vector<T>::data() instead of .array() from Android. This function temaplate is not instantiated so no one noticed that. BUG= chromium:721671 TEST=emerge-soraka media-libs/cros-camera-libcamera_client TEST=Manually use that function and check it still compile. Change-Id: I4d1a6e4f3d11c0fc0548bdc6a91d4eb55dba3899 Reviewed-on: https://chromium-review.googlesource.com/983278 Commit-Ready: Shik Chen <shik@chromium.org> Tested-by: Shik Chen <shik@chromium.org> Reviewed-by: Ricky Liang <jcliang@chromium.org> [modify] https://crrev.com/1e50b07a4cb05c1311688ce186d295ad4d018d59/android/libcamera_client/include/camera/camera_metadata.h [modify] https://crrev.com/1e50b07a4cb05c1311688ce186d295ad4d018d59/android/libcamera_client/include/diff/camera_metadata.h.diff
Comment 1 by hywu@chromium.org
, May 12 2017