New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721660 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: May 2017
Cc:
nyerramilli@chromium.org
tasak@google.com
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Profile image appears shifted from it's original position.

Reported by avsha...@etouch.net, May 12 2017 
Chrome Version : 60.0.3097.0 (Official Build) fca776d5b4979b1f9d86926bfb6d3fb14a0343f3-refs/heads/master@{#471158} 32/64 bit
OS : Windows (7,8,10), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, click on 'Avatar' icon and observe spacing at the left of 'Profile' image.

Actual : Profile icon appears shifted from it's original position.

Expected : Profile icon should be in it's proper position.

This is a regression issue broken in ‘M-60’, below is the Manual Regression range and will soon update other info.
Good build : 60.0.3095.0
Bad build : 60.0.3096.0

Note : Above issue is not seen on Mac 10.11.6 & 10.12.1 OS.
Actual_Profile.mp4
635 KB View Download
Act_Exp_Profile.png
25.2 KB View Download

Comment 1 by avsha...@etouch.net, May 12 2017

Labels: hasbisect
Owner: tasak@google.com
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/43ae6a4ea6c789b9ce52f502a3bb9707b849c2a5..cb0276c1cd972c33c68a04e2f17e6444ce520d19?pretty=fuller&n=10000

Suspecting : r 470681 from Narrow Bisect 

@tasak : Could you please look into the issue and if possible please help to assign it to concern owner.

Thank you!

Comment 2 by tasak@google.com, May 12 2017

Cc: tasak@google.com
Owner: bsep@chromium.org
Obviously this issue is not caused by r470681.

So I've just finished manual bisect.
0f0b3b210e12735f095829d1ee1277fe60de5d5b ... ok
a42af916f8540c65e68d780e37bc07a8230eb5ba ... ng

I think, r470675 causes this issue.

bsep@, would you take a look at this issue?

Comment 3 by bsep@chromium.org, May 12 2017 

Oh yes, that's probably me. I'll take a look. I even tested that UI, I guess I didn't notice it had shifted.
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d5a6e2316c416cd9e012430dd473fe1fadc953d

commit 2d5a6e2316c416cd9e012430dd473fe1fadc953d
Author: bsep <bsep@chromium.org>
Date: Tue May 16 20:43:25 2017

Fix the main profile button avatar having too much padding.

Before I landed crrev.com/2859193004 GridLayout didn't take into account
the view's border. The main profile button was adding its own padding to
account for that problem. After that patch landed it meant it was
doubly-padded. This patch removes the extra padding.

BUG= 721660 

Review-Url: https://codereview.chromium.org/2876343002
Cr-Commit-Position: refs/heads/master@{#472211}

[modify] https://crrev.com/2d5a6e2316c416cd9e012430dd473fe1fadc953d/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Comment 5 by bsep@chromium.org, May 16 2017

Status: Fixed (was: Assigned)

Comment 6 by sureshkumari@chromium.org, May 23 2017

Labels: TE-Verified-60.0.3107.4 TE-Verified-M60
Tested the issue on windows-7 and Linux Ubuntu 14.04 using chrome version#60.0.3107.4 with the steps mentioned in comment #0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
721660.mp4
315 KB View Download
►

Sign in to add a comment