Move FrameSelection::CurrentForm() to ContextMenuImpl |
|||
Issue descriptionSince FrameSelection::CurrentForm() is used only in ContextMenuClientImpl::ShowContextMenu(), we should move it to ContextMenuClientImp.cpp to simply FrameSeletion.cpp We can also move - ScanForForm() - AssociatedFormElement() too.
,
May 15 2017
I'm a virtual owner. tanvir.rizvi@ is working this.
,
May 19 2017
In review http://crrev.com/2881013003
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a34d0750b0cd0db8bdfef1e6a5f5b6be02e984ca commit a34d0750b0cd0db8bdfef1e6a5f5b6be02e984ca Author: tanvir.rizvi <tanvir.rizvi@samsung.com> Date: Fri May 19 11:22:49 2017 Move FrameSelection::CurrentForm() to ContextMenuClientImpl This CL moved CurrentForm logic from FrameSelection to ContextMenuClientImpl. Currently CurrentForm() was used only by ContextMenuClientImpl in ContextMenuClientImpl::ShowContextMenu(). BUG= 721653 Review-Url: https://codereview.chromium.org/2881013003 Cr-Commit-Position: refs/heads/master@{#473158} [modify] https://crrev.com/a34d0750b0cd0db8bdfef1e6a5f5b6be02e984ca/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/a34d0750b0cd0db8bdfef1e6a5f5b6be02e984ca/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/a34d0750b0cd0db8bdfef1e6a5f5b6be02e984ca/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
,
May 22 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tanvir.r...@samsung.com
, May 12 2017