New issue
Advanced search Search tips

Issue 721628 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[devtools] command+f doesn't hide search box

Reported by kaycebas...@gmail.com, May 12 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3096.0 Safari/537.36

Steps to reproduce the problem:
1. Go to Sources panel.
2. Open a file.
3. Press Command+F to open the search box.
4. Press Command+F again to close it.

What is the expected behavior?

What went wrong?
Search box doesn't close.

Did this work before? Yes 

Chrome version: 60.0.3096.0  Channel: canary
OS Version: OS X 10.12.4
Flash Version: 

Assigning to myself. I found this while exploring the DevTools code and I think I found the bug.
 

Comment 1 by kayce@chromium.org, May 12 2017

Owner: kayce@chromium.org

Comment 2 by kayce@google.com, May 12 2017

Owner: kayce@google.com

Comment 3 by kayce@google.com, May 12 2017

Owner: ----
I guess I should remove myself as owner to make sure that somebody from the team sees this

Comment 4 by ajha@chromium.org, May 12 2017

Labels: Needs-Triage-M60 Needs-Bisect
Cc: kkaluri@chromium.org
Labels: -Needs-Bisect -Needs-Triage-M60 M-60 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.4 with chrome stable #58.0.3029.110, Canary #60.0.3096.0 and also in earlier version M30-#30.0.1549.0

This is a non-regression issue marking it as untriaged

Attaching a screen-cast for reference.
Issue 721628.mp4
1.6 MB View Download

Comment 6 by l...@chromium.org, May 15 2017

Owner: l...@chromium.org
Thanks for the report.  It looks like the current behavior was present since Chrome 47.

The current behavior matches the Chrome Find bar, which closes on clicking the 'X' or pressing Escape, similar to Sublime and VSCode as well.  Do you know of other programs that have this pattern?

Comment 7 by l...@chromium.org, Aug 14 2017

Status: Archived (was: Untriaged)
Marking as Archived.  There is already an existing 'Cancel' button and pressing 'Esc' will close the search.  If there is stronger interest and other examples of other tools that have this pattern, we should reconsider.

Sign in to add a comment