ext4crypto migration: Migration UI is shown for supervised user creation flow. |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Prepare a ecryptfs user A. (2) In the log-in screen, press "..." next to the "add person" menu and start adding supervised user. (3) Choose the user A as the manager and enter the password. What is the expected result? What happens instead? "Install critical update" screen is shown. Looks really confusing for the user since in this flow the user didn't even think of using the user A's data at this point at all.
,
May 12 2017
GetUserFlow() is used to determine the case here https://codereview.chromium.org/2513473006/diff/60001/chrome/browser/chromeos/arc/arc_session_manager.cc which seems to be set from https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc?type=cs&l=220
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77f5935267dfb3f96b9194b18e9b824ba086ea74 commit 77f5935267dfb3f96b9194b18e9b824ba086ea74 Author: fukino <fukino@chromium.org> Date: Mon May 15 04:07:32 2017 cros: Stop showing migration UI in some conditions where users can't start ARC. In following cases, we don't need to force dircrypto since ARC can not run. Let's not show the migration UI in such cases. 1) When a user is logging in to the account to add an supervised user. 2) When a user is logging in as a secondary user in multi-profile sessoin. These conditions do not affect the banners on user pods. BUG= 721622 , 721623 TEST=manually tested the cases listed in the CL description. Review-Url: https://codereview.chromium.org/2877943002 Cr-Commit-Position: refs/heads/master@{#471658} [modify] https://crrev.com/77f5935267dfb3f96b9194b18e9b824ba086ea74/chrome/browser/chromeos/login/existing_user_controller.cc
,
May 15 2017
,
May 16 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93ece3922ada41c1f763201d8b8e1a04cd40c3af commit 93ece3922ada41c1f763201d8b8e1a04cd40c3af Author: Naoki Fukino <fukino@chromium.org> Date: Tue May 16 08:57:42 2017 cros: Stop showing migration UI in some conditions where users can't start ARC. In following cases, we don't need to force dircrypto since ARC can not run. Let's not show the migration UI in such cases. 1) When a user is logging in to the account to add an supervised user. 2) When a user is logging in as a secondary user in multi-profile sessoin. These conditions do not affect the banners on user pods. BUG= 721622 , 721623 TEST=manually tested the cases listed in the CL description. Review-Url: https://codereview.chromium.org/2877943002 Cr-Original-Commit-Position: refs/heads/master@{#471658} Review-Url: https://codereview.chromium.org/2884203002 . Cr-Commit-Position: refs/branch-heads/3071@{#577} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/93ece3922ada41c1f763201d8b8e1a04cd40c3af/chrome/browser/chromeos/login/existing_user_controller.cc
,
May 16 2017
,
May 19 2017
Verified on Kevin cros:9567.0.0/60.0.3103.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fukino@chromium.org
, May 12 2017Components: UI>Shell>StartScreen
Status: Started (was: Assigned)