New issue
Advanced search Search tips

Issue 721619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Desktop: show card icon type as the user is typing the number

Project Member Reported by ma...@chromium.org, May 12 2017

Issue description

As the user types a credit card number (e.g., 4-1-1...), the appropriate card issuer logo should show on the right of the field.


 

Comment 1 by ma...@chromium.org, May 23 2017

Owner: ma...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe9253353485376a03c2c35bdd462922ecb80af

commit dbe9253353485376a03c2c35bdd462922ecb80af
Author: mathp <mathp@chromium.org>
Date: Tue May 23 21:28:15 2017

[Payments] Changes to validation in the Credit Card editor

Several changes are bundled here:
* Card icons will now dim dynamically as the network is selected.
* ValidatingTextfield::IsValid no longer has side effects
* Error labels are refreshed differently
* ValidationDelegate now gets passed |was_blurred| for textfield, to
  allow performing some tasks before the blur (selecting card icons).
* Reverse the validity logic on the expiration custom view (oops).

BUG= 721619 
TEST=existing

Review-Url: https://codereview.chromium.org/2896263002
Cr-Commit-Position: refs/heads/master@{#474060}

[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/validating_combobox.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/validating_textfield.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/validating_textfield_unittest.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/chrome/browser/ui/views/payments/validation_delegate.h
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/components/autofill/core/browser/autofill_data_util.cc
[modify] https://crrev.com/dbe9253353485376a03c2c35bdd462922ecb80af/components/autofill/core/browser/autofill_data_util.h

Comment 3 by ma...@chromium.org, May 23 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment