New issue
Advanced search Search tips

Issue 721617 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cbuildbot_launch should generate Monarch metrics.

Project Member Reported by dgarr...@chromium.org, May 12 2017

Issue description

EOM
 

Comment 1 by aut...@google.com, May 16 2017

Labels: -current-issue
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e0d776c5042e215afdd8617e4cbfd977b0ff0131

commit e0d776c5042e215afdd8617e4cbfd977b0ff0131
Author: Don Garrett <dgarrett@google.com>
Date: Fri May 19 18:18:08 2017

metrics: Add a SuccessCounter context manager.

Add a context manager to make it easier to count when a block is
successful or fails. The block is assumed to fail if it raises an
exception, or to be successful otherwise.

BUG= chromium:721617 
TEST=Unittests

Change-Id: I4f7ae7df84feca6828a10d9cb8a186193a662926
Reviewed-on: https://chromium-review.googlesource.com/506649
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/e0d776c5042e215afdd8617e4cbfd977b0ff0131/lib/metrics_unittest.py
[modify] https://crrev.com/e0d776c5042e215afdd8617e4cbfd977b0ff0131/lib/metrics.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/acbb239da72f10ee8e45b6d964ad40b6e39bec03

commit acbb239da72f10ee8e45b6d964ad40b6e39bec03
Author: Don Garrett <dgarrett@google.com>
Date: Wed May 24 06:59:28 2017

cbuildbot_launch: Add Monarch metrics.

Add Monarch metrics for cbuildbot_launch, including performance
numbers for CleanBuildroot, and IntialCheckout.

BUG= chromium:721617 
TEST=Unittests

Change-Id: I6308a7f019ec27729f24ea25d95c829b610a3343
Reviewed-on: https://chromium-review.googlesource.com/503621
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/acbb239da72f10ee8e45b6d964ad40b6e39bec03/lib/metrics_unittest.py
[modify] https://crrev.com/acbb239da72f10ee8e45b6d964ad40b6e39bec03/scripts/cbuildbot_launch.py
[modify] https://crrev.com/acbb239da72f10ee8e45b6d964ad40b6e39bec03/lib/metrics.py
[modify] https://crrev.com/acbb239da72f10ee8e45b6d964ad40b6e39bec03/scripts/cbuildbot_launch_unittest.py

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment