New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Payments] Desktop: Order summary amounts should be right aligned

Project Member Reported by ma...@chromium.org, May 12 2017

Issue description

See before and after screenshot of amounts in order summary screen, which should be right-aligned (trailing)
 
Screen Shot 2017-05-11 at 9.28.44 PM.png
52.4 KB View Download
Screen Shot 2017-05-11 at 9.32.25 PM.png
53.6 KB View Download

Comment 1 by ma...@chromium.org, May 12 2017

Cc: bbergher@chromium.org
Hi Bruno, I tried to interpret your latest comments saying the amounts should be left aligned. They are left aligned on Canary, and I think it looks worse than right aligned. Perhaps we are missing a nuance with currency codes?

Also right aligned is done in the Payment Sheet
Screen Shot 2017-05-12 at 9.10.27 AM.png
14.5 KB View Download
Sorry, I'm not sure I understand, and I couldn't find my comment about this. Right aligned seems right.
Project Member

Comment 3 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f524d54f71aac7020e792a364a3155e7fd2b445

commit 5f524d54f71aac7020e792a364a3155e7fd2b445
Author: mathp <mathp@chromium.org>
Date: Fri May 12 19:24:32 2017

[Payments] Order summary amounts are now right-aligned (trailing)

BUG= 721613 
TEST=visual

Review-Url: https://codereview.chromium.org/2878813004
Cr-Commit-Position: refs/heads/master@{#471406}

[modify] https://crrev.com/5f524d54f71aac7020e792a364a3155e7fd2b445/chrome/browser/ui/views/payments/order_summary_view_controller.cc

Comment 4 by ma...@chromium.org, May 12 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment