[Payments] Desktop: Error screen has a tiny Close button |
|||||||
Issue description(1) https://rsolomakhin.github.io/pr/ko/fail/ (2) Do transaction, get to error screen. The Close button is ugly, don't know why! This is on Mac and only *without* the secondary-ui-md flag, may happen on other platforms. Attaching screenshots with and without the MD flag Assigning to anthony to keep track of Material Design problems
,
Jun 6 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1c191929b42a21aaa181698e569dca8618ed6df commit f1c191929b42a21aaa181698e569dca8618ed6df Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Thu Jun 08 16:27:22 2017 [Web Payments] Change error sheet Close button to primary button Bug: 721607 Change-Id: I59de7742ef30793ae32ca5d41839ca226d1ecca9 Reviewed-on: https://chromium-review.googlesource.com/527254 Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#477990} [modify] https://crrev.com/f1c191929b42a21aaa181698e569dca8618ed6df/chrome/browser/ui/views/payments/error_message_view_controller.cc [modify] https://crrev.com/f1c191929b42a21aaa181698e569dca8618ed6df/chrome/browser/ui/views/payments/error_message_view_controller.h [modify] https://crrev.com/f1c191929b42a21aaa181698e569dca8618ed6df/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/f1c191929b42a21aaa181698e569dca8618ed6df/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
,
Jun 8 2017
,
Jun 9 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbc1f7aa3afb752f243c3b18667f75b0989b71bb commit bbc1f7aa3afb752f243c3b18667f75b0989b71bb Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Fri Jun 09 18:36:50 2017 Merge - [Web Payments] Change error sheet Close button to primary button TBR=anthonyvd@chromium.org (cherry picked from commit f1c191929b42a21aaa181698e569dca8618ed6df) Bug: 721607 Change-Id: I59de7742ef30793ae32ca5d41839ca226d1ecca9 Reviewed-on: https://chromium-review.googlesource.com/527254 Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#477990} Reviewed-on: https://chromium-review.googlesource.com/529609 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#290} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/bbc1f7aa3afb752f243c3b18667f75b0989b71bb/chrome/browser/ui/views/payments/error_message_view_controller.cc [modify] https://crrev.com/bbc1f7aa3afb752f243c3b18667f75b0989b71bb/chrome/browser/ui/views/payments/error_message_view_controller.h [modify] https://crrev.com/bbc1f7aa3afb752f243c3b18667f75b0989b71bb/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/bbc1f7aa3afb752f243c3b18667f75b0989b71bb/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
,
Jun 13 2017
Verified the fix on Mac 10.12.5 using Chrome dev version #61.0.3128.0 as per the comment #0. Attaching screen shot for reference. Observed that the error screen doesn't have a tiny Close button anymore. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jun 27 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ma...@chromium.org
, Jun 5 2017Status: Assigned (was: Available)