Successful translation erroneously reported on too little text |
|||
Issue descriptionChrome Version: 58.0.3029.110 (Official Build) (64-bit) OS: Linux What steps will reproduce the problem? (1) Load a page with little-to-no text (e.g. about:blank). (2) Translate the page (through the right-click menu). (3) Observe the error message bubble. (4) Click the translate icon at the right of the omnibar. What is the expected result? A bubble confirming that the page has not been translated. What happens instead? A bubble suggesting that the page has been successfully translated.
,
May 24 2017
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5ec8bec81e8f54e11e0367836294357dd99c915 commit f5ec8bec81e8f54e11e0367836294357dd99c915 Author: gajendra.n <gajendra.n@samsung.com> Date: Tue Jun 13 03:56:57 2017 Successful translation erroneously reported on page with too little text Before showing the translation bubble, check if there was an error during previous translation. The previous error status will be set in LanguageState as bool value and is checked when browser command Translate is executed. This sets TRANSLATE_STEP_TRANSLATE_ERROR as next step to show appropriate error message in the popup. TEST= (1) Load a page with little-to-no text (e.g. about:blank). (2) Translate the page (through the right-click menu). (3) Observe the error message bubble. (4) Click the translate icon at the right of the omnibar. (5) Error message bubble seen in (3) should be seen again. BUG= 721596 R=groby@chromium.org Review-Url: https://codereview.chromium.org/2900603003 Cr-Commit-Position: refs/heads/master@{#478895} [modify] https://crrev.com/f5ec8bec81e8f54e11e0367836294357dd99c915/chrome/browser/translate/translate_manager_browsertest.cc [modify] https://crrev.com/f5ec8bec81e8f54e11e0367836294357dd99c915/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/f5ec8bec81e8f54e11e0367836294357dd99c915/components/translate/core/browser/language_state.cc [modify] https://crrev.com/f5ec8bec81e8f54e11e0367836294357dd99c915/components/translate/core/browser/language_state.h [modify] https://crrev.com/f5ec8bec81e8f54e11e0367836294357dd99c915/components/translate/core/browser/translate_manager.cc
,
Jun 20 2017
Should this be marked as fixed, Jon?
,
Jun 21 2017
gajendra.n@: Is this fixed now?
,
Jul 20 2017
I believe this is fixed now. Please reopen if it is not fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by gajendr...@samsung.com
, May 22 2017