New issue
Advanced search Search tips

Issue 721588 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 676108



Sign in to add a comment

[TTS] Move ML feature extraction to inference-time

Project Member Reported by donnd@chromium.org, May 11 2017

Issue description

When we log ML features, that should all be done at inference-time rather than when the outcome is available.  Right now we do all the logging when we also have the outcome, but this is unwise because we could end up logging something that we can't act upon appropriately.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a8618b26560b57be00a6d18e0af01aeac89681f

commit 0a8618b26560b57be00a6d18e0af01aeac89681f
Author: donnd <donnd@chromium.org>
Date: Wed May 31 21:01:51 2017

[TTS] Move Ranker logging to inference time.

Changes logging of Ranker features to make sure they are done at
inference-time or beforehand, instead of allowing them to be done
after inference.  Logging of outcomes can be done at any time.

Adds a queue for all the features so they can all be logged at the same
time, or the logging can easily be aborted at the last minute.

Updates handling of before-scroll to have a configurable pause
to allow scrolling after a Tap has been recognized.  Before-scroll
is no longer considered a Ranker-feature: It's handled by the normal
detection of any action that can dismiss the panel during the time
between a tap and showing the UI.

Updates UKM feature-names from all-caps to camelcase.  Removes the
Before-scroll feature from Ranker logging through UKM.

Also remove some leftover Blacklist code that's no longer needed.

BUG= 721588 

Review-Url: https://codereview.chromium.org/2894913003
Cr-Commit-Position: refs/heads/master@{#476021}

[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/BarOverlapTapSuppression.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristics.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/CtrSuppression.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/QuickAnswersHeuristic.java
[modify] https://crrev.com/0a8618b26560b57be00a6d18e0af01aeac89681f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/RecentScrollTapSuppression.java

Comment 2 by donnd@chromium.org, May 31 2017

Status: Fixed (was: Started)

Sign in to add a comment