New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721587 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 721801



Sign in to add a comment

DevTools: [esmodules] Network initiators don't work

Project Member Reported by paulir...@chromium.org, May 11 2017

Issue description

They all point to the HTML

test app: https://paulirish.github.io/es-modules-todomvc/

All but bootstrap.js are requested from inside other network requests.




 
Screen Shot 2017-05-11 at 4.55.03 PM.png
144 KB View Download
Blocking: 721801
Labels: -Pri-2 M-61 Pri-1
Bumping to P1, M61 given that this blocks the devtools MVP bug which blocks ES6 Modules (targeted at M61).

Comment 3 by kouhei@chromium.org, May 29 2017

Cc: hirosh...@chromium.org module-dev@chromium.org
allada@ Do you have cycle to work on this bug? This will block ES6 modules ship.

Comment 4 by kouhei@chromium.org, May 29 2017

I think we can simply plumb the ModuleScriptFetchRequest::referrer_ to the inspector

Comment 5 by kouhei@chromium.org, Jun 12 2017

allada: Would you give update on this?

Comment 6 by allada@chromium.org, Jun 13 2017

Yep sorry this slipped through my email.

I will look into it today and give an update :-)

Comment 7 by allada@chromium.org, Jun 13 2017

Cc: kozyatinskiy@chromium.org
I took a look into what is going on here and the fix will not be able to be squeezed into this quarter. We can add it to our Q3 OKR.

I am not convinced that we can use ModuleScriptFetchRequest::referrer_... It appears that we can easily loose the referrer if the policy deems so.

I believe the best thing to do is to have V8 pass a ScriptLocation of when a new module resource is added to the module tree.

Is adding it to Q3 OKRs good with you?
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/539565/

Comment 10 by phistuck@gmail.com, Jun 28 2017

I think it would be very helpful to know (by order of priority) -
1. The specific module that first triggered loading this module.
2. All of the modules that would have triggered loading this module.
3. Perhaps there should be a module-dependency panel/drawer for showing all of the relationships and dependencies. But this is probably too fancy.

The point is that sometimes loading (running) a module may cause bugs and knowing the way that brought this module to the application would make it much faster to fix.
Status: Fixed (was: Started)
We're working on module-specific features, and I think we'll cover all mentioned use cases. Thanks!
But this particular issue is fixed by [1].

[1] https://chromium-review.googlesource.com/c/539565/


lgtm! thx

Screen Shot 2017-06-29 at 11.04.00 AM.png
199 KB View Download

Sign in to add a comment