Alert when swarmbucket canary template is broken
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/619333547f5d4ae2c466c82836219952f6a30438 commit 619333547f5d4ae2c466c82836219952f6a30438 Author: Nodir Turakulov <nodir@google.com> Date: Fri Jun 02 19:39:45 2017 buildbucket: add canary_build tag Introduce "canary_build" tag. Milo build page can use it to decide whether to display a note that the build may fail due to canary version of infra. Bug: 721571 Change-Id: I9d3fe7c9228fbd915533bb1a10bb3b332766dfff TBR=vadimsh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/522905 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/619333547f5d4ae2c466c82836219952f6a30438/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/619333547f5d4ae2c466c82836219952f6a30438/appengine/cr-buildbucket/test/metrics_test.py [modify] https://crrev.com/619333547f5d4ae2c466c82836219952f6a30438/appengine/cr-buildbucket/metrics.py [modify] https://crrev.com/619333547f5d4ae2c466c82836219952f6a30438/appengine/cr-buildbucket/swarming/test/swarming_test.py [modify] https://crrev.com/619333547f5d4ae2c466c82836219952f6a30438/appengine/cr-buildbucket/swarming/swarmbucket_api.py [modify] https://crrev.com/619333547f5d4ae2c466c82836219952f6a30438/appengine/cr-buildbucket/doc/index.md
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/859ad62bb95e0bc2bf04f0aee7cad5f11c295d6f commit 859ad62bb95e0bc2bf04f0aee7cad5f11c295d6f Author: Nodir Turakulov <nodir@google.com> Date: Fri Jun 02 22:47:45 2017 buildbucket: include canary field in metrics Bug: 721571 Change-Id: I8ca896ee3924e8c604f869e7acec2fe5791f3bfd Reviewed-on: https://chromium-review.googlesource.com/522849 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/859ad62bb95e0bc2bf04f0aee7cad5f11c295d6f/appengine/cr-buildbucket/metrics.py [modify] https://crrev.com/859ad62bb95e0bc2bf04f0aee7cad5f11c295d6f/appengine/cr-buildbucket/test/metrics_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8 commit 9aa4042fcbfbb0d12b00b8389cda61d1ff773db8 Author: Nodir Turakulov <nodir@google.com> Date: Mon Jun 05 21:37:44 2017 buildbucket: make canary concept a first-class citizen Initially the concept of canary was made specific to swarmbucket, but that abstraction leaked the generic metrics.py. The concept is generic enough that we can make it a first-class citizen without sacrificing current buildbucket generality. Add canary and canary_preference fields to Build entity, see model for more details. Update the rest of the code to use them. Bug: 721571 Change-Id: Id271afc17c9edbff794e7aea91530560e5aee358 Reviewed-on: https://chromium-review.googlesource.com/523455 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/README.md [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/api_common.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/test/service_test.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/test/api_test.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/service.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/metrics.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/doc/swarming.md [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/swarming/swarmbucket_api.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/api.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/swarming/test/swarming_test.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/doc/index.md [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/model.py [modify] https://crrev.com/9aa4042fcbfbb0d12b00b8389cda61d1ff773db8/appengine/cr-buildbucket/test/metrics_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6f2962acdbb5fced809fc7f579783a6b63eb562a commit 6f2962acdbb5fced809fc7f579783a6b63eb562a Author: Nodir Turakulov <nodir@google.com> Date: Mon Jun 05 22:23:35 2017 buildbucket: fix api_common.build_to_dict api_common.BuildMessage.canary_preferred has incorrect field type: boolean instead of enum Bug: 721571 Change-Id: Ic05ab4a6c51c506c8c8d1c647c3aecf3c389bd2e Reviewed-on: https://chromium-review.googlesource.com/524441 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/6f2962acdbb5fced809fc7f579783a6b63eb562a/appengine/cr-buildbucket/api_common.py [modify] https://crrev.com/6f2962acdbb5fced809fc7f579783a6b63eb562a/appengine/cr-buildbucket/test/api_common_test.py
Shouldn't this be marked fixed? Nodir, please update.
we have monitoring, but not alerting we don't do kitchen deployments often lately, so I think it should not block migration. Vadim may have different opinion though.
i am not working on this at the moment
Issue 660993 has been merged into this issue.
Comment 1 by no...@chromium.org
, May 11 2017