New issue
Advanced search Search tips

Issue 721570 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: 21
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 695489
issue 721571



Sign in to add a comment

LUCI build monitoring

Project Member Reported by no...@chromium.org, May 11 2017

Issue description

A meta bug to have sufficient monitoring of non-user failures in LUCI builds. Here users are users of LUCI APIs.

See blocked bugs.

 

Comment 1 by no...@chromium.org, May 11 2017

Blockedon: 721571

Comment 2 by no...@chromium.org, May 11 2017

Blockedon: 695489

Comment 3 by efoo@chromium.org, May 23 2017

Labels: LUCI-M1-S2

Comment 4 by efoo@chromium.org, May 23 2017

EstimatedDays: 21
Owner: no...@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by efoo@chromium.org, Jun 9 2017

Labels: LUCI-M1-S3

Comment 6 by efoo@chromium.org, Jun 20 2017

Labels: LUCI-M2-S4 LUCI-M2-Dev2

Comment 7 by efoo@chromium.org, Aug 22 2017

Labels: LUCI-M2-S6

Comment 8 by no...@chromium.org, Aug 29 2017

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cbe264a623d9e5878f91dc1c3208b5625763420c

commit cbe264a623d9e5878f91dc1c3208b5625763420c
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 31 21:15:35 2017

Add recipe deps to the completed_builds table

We want to see a grpah of recipe dep versions used in production. We don't have
to alert on it, so BigQuery will be enough.

Include recipe deps, derived from recipe_engine's package.proto, to the
completed_builds legacy table.

R=iannucci@chromium.org, dnj@chromium.org
BUG= 721570 

Change-Id: If375855957783eaf3b57ac283321f58ecd99df6d
Reviewed-on: https://chromium-review.googlesource.com/641315
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/cbe264a623d9e5878f91dc1c3208b5625763420c/go/src/infra/libs/bqschema/buildevent/completed_builds_legacy.gen.go
[modify] https://crrev.com/cbe264a623d9e5878f91dc1c3208b5625763420c/go/src/infra/tools/bqschemaupdater/raw_events/buildevent_completed_build_legacy.pb.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/2bb02540a2b089dae2fa7c9146322fa4caed092f

commit 2bb02540a2b089dae2fa7c9146322fa4caed092f
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 31 21:31:34 2017

Reland "include Package proto into Result proto"

This relands https://codereview.chromium.org/2802693003
Its descrption:

Kitchen runs recipes using recipe engine and needs to know revisions of
recipe dependencies that were used for a run.

Export entire contents of recipes.cfg in the new result proto.

Bug:  721570 
Change-Id: I52e13260419fc7b84955da2b39d8ca3120c71f07
Reviewed-on: https://chromium-review.googlesource.com/641614
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/2bb02540a2b089dae2fa7c9146322fa4caed092f/recipe_engine/result_pb2.py
[modify] https://crrev.com/2bb02540a2b089dae2fa7c9146322fa4caed092f/recipe_engine/package.py
[modify] https://crrev.com/2bb02540a2b089dae2fa7c9146322fa4caed092f/recipe_engine/run.py
[modify] https://crrev.com/2bb02540a2b089dae2fa7c9146322fa4caed092f/recipe_engine/result.proto

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/91b41ae8cc30cc42880f60e169a854954c78493e

commit 91b41ae8cc30cc42880f60e169a854954c78493e
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Sep 01 00:22:56 2017

Revert "Reland "include Package proto into Result proto""

This reverts commit 2bb02540a2b089dae2fa7c9146322fa4caed092f.

Reason for revert: looks like it broke the world again

See https://bugs.chromium.org/p/chromium/issues/detail?id=761184

Original change's description:
> Reland "include Package proto into Result proto"
> 
> This relands https://codereview.chromium.org/2802693003
> Its descrption:
> 
> Kitchen runs recipes using recipe engine and needs to know revisions of
> recipe dependencies that were used for a run.
> 
> Export entire contents of recipes.cfg in the new result proto.
> 
> Bug:  721570 
> Change-Id: I52e13260419fc7b84955da2b39d8ca3120c71f07
> Reviewed-on: https://chromium-review.googlesource.com/641614
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>

TBR=iannucci@chromium.org,nodir@chromium.org

Change-Id: If458301a6a73ce52f93b3fca2b1ed5b3a98e7012
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721570 
Reviewed-on: https://chromium-review.googlesource.com/646876
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/91b41ae8cc30cc42880f60e169a854954c78493e/recipe_engine/result_pb2.py
[modify] https://crrev.com/91b41ae8cc30cc42880f60e169a854954c78493e/recipe_engine/package.py
[modify] https://crrev.com/91b41ae8cc30cc42880f60e169a854954c78493e/recipe_engine/run.py
[modify] https://crrev.com/91b41ae8cc30cc42880f60e169a854954c78493e/recipe_engine/result.proto

Comment 12 by efoo@chromium.org, Nov 8 2017

Labels: -REQBY-LUCI-M4-OpenBeta REQBY-LUCI-M3-Beta
Status: Archived (was: Started)
this meta bug is no longer useful, see blocking bugs

Comment 14 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-M1-Dev1 -LUCI-M2-Dev2 LUCI-Dev1 LUCI-Dev2

Comment 15 by efoo@chromium.org, Feb 13 2018

Labels: -REQBY-LUCI-M3-Beta REQBY-LUCI-Beta

Sign in to add a comment