New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721562 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 721858



Sign in to add a comment

add tests for "did run" code

Project Member Reported by wfh@chromium.org, May 11 2017

Issue description

We have no good test coverage to make sure that we don't regress the functionality that tells Omaha that Chrome is 'active' via DidRunUpdater in chrome/browser/google/did_run_updater_win.h

We should add these tests so this does not regress.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0762cfd079b91ff195345470c6253e9605716e0c

commit 0762cfd079b91ff195345470c6253e9605716e0c
Author: wfh <wfh@chromium.org>
Date: Thu May 11 23:40:47 2017

Initialize did_run_updater_ in browser startup.

This was mistakenly removed in crrev.com/2621363002.

BUG=721562

Review-Url: https://codereview.chromium.org/2879683004
Cr-Commit-Position: refs/heads/master@{#471121}

[modify] https://crrev.com/0762cfd079b91ff195345470c6253e9605716e0c/chrome/browser/chrome_browser_main_win.cc

Comment 2 by wfh@chromium.org, May 12 2017

Cc: grt@chromium.org
tests could be something like:

 * clear dr key
 * start a browser
 * verify existence of dr key
 * clear dr key
 * start a new tab
 * verify existence of dr key

perhaps?

alternatively we mock out the GoogleUpdateSettings::UpdateDidRunState call and then we can probably do this without having to read/write any registry keys

Comment 3 by wfh@chromium.org, May 12 2017

Labels: Merge-Request-58 Merge-Request-59
verified manually that the 'dr' key is being written on new renderer creation in 60.0.3097.0 so I'm requesting merges for 0762cfd079b91ff195345470c6253e9605716e0c

Comment 4 by wfh@chromium.org, May 12 2017

Blocking: 721858

Comment 5 by gov...@chromium.org, May 12 2017

Cc: abdulsyed@chromium.org
Labels: -Merge-Request-58 -Merge-Request-59 Merge-Approved-59 Merge-Approved-58
Approving merge to M58 branch 3029 and M59 branch 3071 per comment #3 and internal mail thread.
Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fad145ac7c759aebfd5159c76e9edfd4456b03

commit c3fad145ac7c759aebfd5159c76e9edfd4456b03
Author: Will Harris <wfh@chromium.org>
Date: Fri May 12 19:14:26 2017

Merge M59: Initialize did_run_updater_ in browser startup.

This was mistakenly removed in crrev.com/2621363002.

BUG=721562,721858

Review-Url: https://codereview.chromium.org/2879683004
Cr-Commit-Position: refs/heads/master@{#471121}
(cherry picked from commit 0762cfd079b91ff195345470c6253e9605716e0c)

Review-Url: https://codereview.chromium.org/2874933007 .
Cr-Commit-Position: refs/branch-heads/3071@{#534}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/c3fad145ac7c759aebfd5159c76e9edfd4456b03/chrome/browser/chrome_browser_main_win.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 12 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f4d57a007a3931906bc0dd8848e55fcd051bab

commit 60f4d57a007a3931906bc0dd8848e55fcd051bab
Author: Will Harris <wfh@chromium.org>
Date: Fri May 12 19:18:18 2017

Merge M58: Initialize did_run_updater_ in browser startup.

This was mistakenly removed in crrev.com/2621363002.

BUG=721562,721858

Review-Url: https://codereview.chromium.org/2879683004
Cr-Commit-Position: refs/heads/master@{#471121}
(cherry picked from commit 0762cfd079b91ff195345470c6253e9605716e0c)

Review-Url: https://codereview.chromium.org/2881733005 .
Cr-Commit-Position: refs/branch-heads/3029@{#841}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/60f4d57a007a3931906bc0dd8848e55fcd051bab/chrome/browser/chrome_browser_main_win.cc

Cc: -grt@chromium.org gab@chromium.org
Owner: grt@chromium.org
Status: Assigned (was: Untriaged)
Triage: Provisionally assigning to grt@ with gab@ as Cc. Feel free to reassign.

Sign in to add a comment