New issue
Advanced search Search tips

Issue 721553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Blink-Paint



Sign in to add a comment

DOMMatrixInit validate and fixup fails tests for NaN/NaN

Reported by sim...@opera.com, May 11 2017

Issue description

See https://github.com/w3c/web-platform-tests/pull/5896

Spec https://drafts.fxtf.org/geometry/#dommatrixinit-dictionary

> For the purpose of the algorithm above, two WebIDL unrestricted double values are the same if they have identical IEEE 754 double-precision bit patterns.
>
> This means that two NaN values are the same.
 

Comment 1 by sim...@opera.com, May 12 2017

Summary: DOMMatrixInit validate and fixup fails tests for 0/-0 and NaN/NaN (was: DOMMatrixInit validate and fixup fails tests for 0/-1 and NaN/NaN)
Also see https://github.com/w3c/fxtf-drafts/issues/152 about 0/-0...

Comment 2 by fs...@chromium.org, May 12 2017

Cc: -fs...@chromium.org
Owner: fs...@chromium.org
Status: Available (was: Untriaged)

Comment 3 by sim...@opera.com, May 15 2017

https://github.com/w3c/fxtf-drafts/pull/159

With the updated tests in https://github.com/w3c/web-platform-tests/pull/5896 Chromium only fails the NaN test.

Comment 4 by sim...@opera.com, May 15 2017

Summary: DOMMatrixInit validate and fixup fails tests for NaN/NaN (was: DOMMatrixInit validate and fixup fails tests for 0/-0 and NaN/NaN)

Comment 5 by fs...@chromium.org, Jun 28 2017

Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93432c4ba6fabf0e9a9beececdf05bb34512730a

commit 93432c4ba6fabf0e9a9beececdf05bb34512730a
Author: Fernando Serboncini <fserb@chromium.org>
Date: Fri Jun 30 15:57:35 2017

Fix DOMMatrix initialization with NaN/NaN

Bug:  721553 
Change-Id: I05b94b482104d6375bddcfa4573a657101a031b2
Reviewed-on: https://chromium-review.googlesource.com/552380
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483715}
[delete] https://crrev.com/91a26f05e5d9c5a20d1300db1fbe732d8847d805/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/DOMMatrixInit-validate-fixup-expected.txt
[modify] https://crrev.com/93432c4ba6fabf0e9a9beececdf05bb34512730a/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp

Comment 7 by fs...@chromium.org, Jun 30 2017

Status: Fixed (was: Started)

Sign in to add a comment