New issue
Advanced search Search tips

Issue 721546 link

Starred by 1 user
Status: Fixed
Owner:
reillyg@chromium.org
Closed: May 2017
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Landing page URL not read when allowed origins descriptor read fails

Project Member Reported by reillyg@chromium.org, May 11 2017 
Chrome Version: 60.0.3088.3
OS: All

What steps will reproduce the problem?
(1) Connect a device that responds to a GET_URL request but not a GET_ALLOWED_ORIGINS request.

What is the expected result?
Device landing page notification should be displays.

What happens instead?
No notification is displayed.

The cause of this issue is that in webusb_descriptors.cc ReadUrlDescriptors() will exit early if there was an error reading the allowed origins and not read the landing page URL.

As the allowed origins header has been removed from the WebUSB spec this issue is blocking devices from shipping without implementing this (now undocumented) feature.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84869d699fe82560ca9ac3f30c5b959110af30bf

commit 84869d699fe82560ca9ac3f30c5b959110af30bf
Author: reillyg <reillyg@chromium.org>
Date: Fri May 12 00:24:36 2017

Read WebUSB landing page even if allowed origin read fails

Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB
devices may only support the GET_URL request used for reading the
landing page from the device. This patch fixes the descriptor reading
logic so that this is supported.

(Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed
entirely as part of  issue 711443 .)

BUG= 721546 

Review-Url: https://codereview.chromium.org/2876463008
Cr-Commit-Position: refs/heads/master@{#471141}

[modify] https://crrev.com/84869d699fe82560ca9ac3f30c5b959110af30bf/device/usb/webusb_descriptors.cc

Comment 2 by reillyg@chromium.org, May 12 2017

Labels: Merge-Request-59
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, May 12 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00121a64ad04ba8f63eeb958c834d59c5700217

commit f00121a64ad04ba8f63eeb958c834d59c5700217
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri May 12 18:05:42 2017

Read WebUSB landing page even if allowed origin read fails

Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB
devices may only support the GET_URL request used for reading the
landing page from the device. This patch fixes the descriptor reading
logic so that this is supported.

(Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed
entirely as part of  issue 711443 .)

BUG= 721546 

Review-Url: https://codereview.chromium.org/2876463008
Cr-Original-Commit-Position: refs/heads/master@{#471141}
Review-Url: https://codereview.chromium.org/2879633004 .
Cr-Commit-Position: refs/branch-heads/3071@{#529}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f00121a64ad04ba8f63eeb958c834d59c5700217/device/usb/webusb_descriptors.cc
►

Sign in to add a comment