New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721526 link

Starred by 1 user
Status: Fixed
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

only track subframes that are children of the currently committed frame

Project Member Reported by bmcquade@chromium.org, May 11 2017 
Josh and I discovered that it may be the case that if a navigation in a child frame starts, then the main frame commits, then that child frame nav finishes, we may get notified for it and incorrectly attribute it to the currently committed load. Josh pointed out that we can use GetParentFrame() to successfully traverse the parent hierarchy in this case. We should add this filtering when tracking commits.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/356b56ebd085219c574858880d8ef0d15226bfda

commit 356b56ebd085219c574858880d8ef0d15226bfda
Author: bmcquade <bmcquade@chromium.org>
Date: Fri May 12 00:35:18 2017

Improve subframe navigation tracking.

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG= 721526 

Review-Url: https://codereview.chromium.org/2876793004
Cr-Commit-Position: refs/heads/master@{#471146}

[modify] https://crrev.com/356b56ebd085219c574858880d8ef0d15226bfda/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Comment 2 by bmcquade@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment