We need mojo API for communication between chrome and ash for lockscreen. See a work in progress document here: go/cros-lockscreen-mojo
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bbdd107bcc11f6b41469249dfc51bac7b25eb01 commit 2bbdd107bcc11f6b41469249dfc51bac7b25eb01 Author: xiaoyinh <xiaoyinh@chromium.org> Date: Thu May 18 23:29:42 2017 mojo api for view based lockscreen. BUG= 721524 Review-Url: https://codereview.chromium.org/2876673002 Cr-Commit-Position: refs/heads/master@{#472966} [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/BUILD.gn [add] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/login/DEPS [add] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/login/lock_screen_controller.cc [add] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/login/lock_screen_controller.h [add] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/login/lock_screen_controller_unittest.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/mojo_interface_factory.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/mus/DEPS [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/mus/manifest.json [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/mus/window_manager_application.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/public/interfaces/BUILD.gn [add] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/public/interfaces/lock_screen.mojom [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/shell.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/shell.h [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/test/DEPS [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/ash/test/ash_test_helper.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/chrome/browser/ui/BUILD.gn [add] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/chrome/browser/ui/ash/lock_screen_client.cc [add] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/chrome/browser/ui/ash/lock_screen_client.h [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/2bbdd107bcc11f6b41469249dfc51bac7b25eb01/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f6fa0ed40b236032707e7af67009ce53817e627 commit 9f6fa0ed40b236032707e7af67009ce53817e627 Author: xiaoyinh <xiaoyinh@chromium.org> Date: Wed Jun 07 19:22:32 2017 Adding mojo calls for easy unlock service BUG= 721524 Review-Url: https://codereview.chromium.org/2903353003 Cr-Commit-Position: refs/heads/master@{#477722} [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/ash/login/lock_screen_controller.cc [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/ash/login/lock_screen_controller.h [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/ash/login/lock_screen_controller_unittest.cc [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/ash/login/mock_lock_screen_client.h [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/ash/public/interfaces/lock_screen.mojom [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/lock/screen_locker.h [add] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/lock/views_screen_locker.cc [add] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/lock/views_screen_locker.h [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/screens/user_selection_screen.h [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/ui/views/user_board_view.h [add] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/user_selection_screen_proxy.cc [add] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/chromeos/login/user_selection_screen_proxy.h [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/ui/ash/lock_screen_client.cc [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/ui/ash/lock_screen_client.h [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/components/proximity_auth/screenlock_bridge.cc [modify] https://crrev.com/9f6fa0ed40b236032707e7af67009ce53817e627/components/proximity_auth/screenlock_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73 commit f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73 Author: xiaoyinh <xiaoyinh@chromium.org> Date: Tue Jun 13 20:50:27 2017 Adding mojo calls for several lock screen related operations. This CL does the following: 1. Adding Mojo calls to: a. Notify chrome when user pod is focused/no user pod is focused, and when user has reached maximum incorrect password attempts. b. Send request to chrome to load wallpaper and sign out current user. c. Notify lockscreen views when pin unlock is enabled/disabled. 2. Move common helper functions out of SignInScreenHandler into lock_screen_utils so both WebUI handlers and Views based handlers (ViewsScreenLocker) can use. BUG= 721524 Review-Url: https://codereview.chromium.org/2923773003 Cr-Commit-Position: refs/heads/master@{#479142} [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/ash/login/lock_screen_controller.cc [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/ash/login/lock_screen_controller.h [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/ash/login/lock_screen_controller_unittest.cc [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/ash/login/mock_lock_screen_client.h [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/ash/public/interfaces/lock_screen.mojom [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/chromeos/login/lock/views_screen_locker.cc [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/chromeos/login/lock/views_screen_locker.h [add] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/chromeos/login/lock_screen_utils.cc [add] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/chromeos/login/lock_screen_utils.h [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/ui/ash/lock_screen_client.cc [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/ui/ash/lock_screen_client.h [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/069eea183d2ddb590c7e5e23ff786ea4ad45dffc commit 069eea183d2ddb590c7e5e23ff786ea4ad45dffc Author: Sarah Hu <xiaoyinh@chromium.org> Date: Fri Sep 08 01:28:40 2017 Hash pin using existing hash algorithm Pin is hashed differently than password in PinStorage. This CL updates LockScreenController to hash pin using its existing hash algorithm. Bug: 721524 Change-Id: I90f8691aee7fb4dfe179df4fab5de7f6a0ee6c2a Reviewed-on: https://chromium-review.googlesource.com/653857 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#500473} [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/lock_screen_controller.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/lock_screen_controller.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/lock_screen_controller_unittest.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/ui/lock_screen.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/ui/lock_screen.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/public/cpp/ash_pref_names.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/public/cpp/ash_pref_names.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ash/shell.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/login/lock/views_screen_locker.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/login/quick_unlock/pin_storage.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/common/pref_names.cc [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/chrome/common/pref_names.h [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/069eea183d2ddb590c7e5e23ff786ea4ad45dffc/ui/login/account_picker/user_pod_row.js
Comment 1 by bugdroid1@chromium.org
, May 18 2017