Issue metadata
Sign in to add a comment
|
Polymer rietveld saving issues broken xhr.response is null |
||||||||||||||||||||||||
Issue descriptionGoogle Chrome 60.0.3096.0 (Official Build) canary (64-bit) Revision c714b929856634f69e66588db294ccb8b785ad25-refs/heads/master@{#470759} OS Mac OS X JavaScript V8 6.0.189 What steps will reproduce the problem? (1) Go to https://codereview.chromium.org/2855523002/ (2) Make sure the non-deprecated UI is enabled in Settings. (3) Click "edit" in the top right. (4) Click save. What is the expected result? Dialog should disappear. What happens instead? Dialog does not disappear. This is because the XHR .response property is now null causing an exception on this line: var errorData = parseFormErrorData(xhr.response); You can see this if you tell the devtools to stop on caught exceptions too. This works in Stable 58.
,
May 12 2017
Might be dup of bug 721225 .
,
May 12 2017
,
May 15 2017
As this issue is similar to issue #721225 ,merging this issue. Please feel free to undup if it is not similar. Thank you..!!
,
May 15 2017
Adding more info: Able to reproduce the issue on Windows 7, Mac 10.12.4 & Ubuntu 14.04 using latest Canary-60.0.3099.0. Manual Bisect: ------------- Good-60.0.3083.0 -Revision-467821 Bad-60.0.3084.0 -Revision-468182 Per revision bisect info: ------------------------- You are probably looking for a change made after 468029 (known good), but no later than 468030 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/f95d508c15009e62252c38701982042740289d84..716a136332fbd8efc12a3892b6ae2a6c0be94ba7 Since the root cause is similar to #721225, hence merging this issue. japhet@ please take a look into this issue. Thanks..!! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tkent@chromium.org
, May 12 2017Labels: -Type-Bug Needs-Bisect Type-Bug-Regression