New issue
Advanced search Search tips

Issue 721516 link

Starred by 1 user
Status: Fixed
Owner:
pwnall@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 713409


Sign in to add a comment

Use WebBlobRegistry::CreateBuilder to avoid copy in IndexedDB large value wrapping

Project Member Reported by pwnall@chromium.org, May 11 2017

Comment 1 by mek@chromium.org, Jan 24 2018 

I think this bug/TODO are outdated. IDBValueWrapper seems to just take the base::span returned by SerializedScriptValue and passes that on to BlobData::AppendBytes. Which results in exactly one copy (from that span into BlobData internal structs).

Comment 2 by pwnall@chromium.org, Jan 24 2018 

Shall I submit a CL, or would you prefer to do that?
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1dcbd0eb04f3624b2cc297a585b9c663ea43080

commit b1dcbd0eb04f3624b2cc297a585b9c663ea43080
Author: Victor Costan <pwnall@chromium.org>
Date: Wed Jan 24 20:39:40 2018

IndexedDB: Remove outdated TODO.

Bug:  721516 
Change-Id: I80ef1e4b11cb44019f2136c60d3bb05431fa7916
Reviewed-on: https://chromium-review.googlesource.com/883979
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531670}
[modify] https://crrev.com/b1dcbd0eb04f3624b2cc297a585b9c663ea43080/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp

Comment 4 by pwnall@chromium.org, Jan 24 2018

Owner: pwnall@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment