Title says it all. I'm planning on starting with Configuration / Activation.
Title says it all. I'm planning on starting with Configuration / Activation. For more information about tracing, see documentation in trace_event_common: https://cs.chromium.org/chromium/src/base/trace_event/common/trace_event_common.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e6d3357dce6196a843b7967695e16a4ae82c663 commit 8e6d3357dce6196a843b7967695e16a4ae82c663 Author: csharrison <csharrison@chromium.org> Date: Mon May 15 16:33:41 2017 [subresource_filter] Add debugging trace events around activation This is the first of a few CLs adding helpful traces to the feature. BUG=721512 Review-Url: https://codereview.chromium.org/2875033004 Cr-Commit-Position: refs/heads/master@{#471788} [modify] https://crrev.com/8e6d3357dce6196a843b7967695e16a4ae82c663/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/8e6d3357dce6196a843b7967695e16a4ae82c663/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/8e6d3357dce6196a843b7967695e16a4ae82c663/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/8e6d3357dce6196a843b7967695e16a4ae82c663/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc [modify] https://crrev.com/8e6d3357dce6196a843b7967695e16a4ae82c663/components/subresource_filter/core/browser/subresource_filter_features_test_support.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eff0ce486ad4cbb28bd6fb825688feb68903679 commit 3eff0ce486ad4cbb28bd6fb825688feb68903679 Author: csharrison <csharrison@chromium.org> Date: Tue May 23 20:57:22 2017 [subresource_filter] Add TRACE_EVENT probes for frame activation BUG=721512 Review-Url: https://codereview.chromium.org/2895263004 Cr-Commit-Position: refs/heads/master@{#474046} [modify] https://crrev.com/3eff0ce486ad4cbb28bd6fb825688feb68903679/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/3eff0ce486ad4cbb28bd6fb825688feb68903679/components/subresource_filter/core/common/BUILD.gn [add] https://crrev.com/3eff0ce486ad4cbb28bd6fb825688feb68903679/components/subresource_filter/core/common/activation_state.cc [modify] https://crrev.com/3eff0ce486ad4cbb28bd6fb825688feb68903679/components/subresource_filter/core/common/activation_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b25735a10e374dc111c1acc892de70b90d3643f commit 4b25735a10e374dc111c1acc892de70b90d3643f Author: Charles Harrison <csharrison@chromium.org> Date: Thu Jun 22 16:35:22 2017 [subresource_filter] Add async trace events for SB check Bug: 721512 Change-Id: Idec03189f08cc0fddc52c5aa97f1b9124e81fc95 Reviewed-on: https://chromium-review.googlesource.com/544197 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#481556} [modify] https://crrev.com/4b25735a10e374dc111c1acc892de70b90d3643f/components/safe_browsing_db/util.h [modify] https://crrev.com/4b25735a10e374dc111c1acc892de70b90d3643f/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.cc [modify] https://crrev.com/4b25735a10e374dc111c1acc892de70b90d3643f/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55eedcf94d1bf02a4067da12126abad111b69d9e commit 55eedcf94d1bf02a4067da12126abad111b69d9e Author: Charles Harrison <csharrison@chromium.org> Date: Fri Jun 23 17:23:27 2017 [subresource_filter] More tracing around activation Fixes some old trace events and adds a new one around condition matching. Bug: 721512 Change-Id: I1f2dfb0708ea122b998c24a7fe21ca595c900160 Reviewed-on: https://chromium-review.googlesource.com/544195 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#481939} [modify] https://crrev.com/55eedcf94d1bf02a4067da12126abad111b69d9e/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/55eedcf94d1bf02a4067da12126abad111b69d9e/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/55eedcf94d1bf02a4067da12126abad111b69d9e/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/55eedcf94d1bf02a4067da12126abad111b69d9e/components/subresource_filter/core/common/activation_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7912e820fd868a331d7e512a3353806dfe5a3b2 commit e7912e820fd868a331d7e512a3353806dfe5a3b2 Author: Charles Harrison <csharrison@chromium.org> Date: Sat Aug 19 03:37:39 2017 [subresource_filter] Add traces/UMA around ruleset verification Not only will the UMA give us latency numbers, but it will ensure that we aren't mapping in the ruleset when we shouldn't be. Bug: 721512 Change-Id: I705bfccc69b7b7da582532338d625641b399f705 Reviewed-on: https://chromium-review.googlesource.com/546137 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#495796} [modify] https://crrev.com/e7912e820fd868a331d7e512a3353806dfe5a3b2/components/subresource_filter/content/browser/verified_ruleset_dealer.cc [modify] https://crrev.com/e7912e820fd868a331d7e512a3353806dfe5a3b2/components/subresource_filter/core/common/indexed_ruleset.cc [modify] https://crrev.com/e7912e820fd868a331d7e512a3353806dfe5a3b2/tools/metrics/histograms/histograms.xml
Some places where it would be good to add traces: - The AsyncDocumentSubresourceFilter - Interesting RulesetService methods - Matched rules (maybe) +ericrobinson, this is an easy one if you're interested.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47d5537ba10dd8b11c1402ac3e451940b5035724 commit 47d5537ba10dd8b11c1402ac3e451940b5035724 Author: John Delaney <johnidel@chromium.org> Date: Mon Jun 25 23:17:00 2018 Add trace events to RulesetService Add trace of prefs format and content version at RulesetService creation. Add trace of invalid Indexed Ruleset file read. Bug: 721512 Change-Id: I6809a2cccb8903889b74e64a8c08788ff3c8422a Reviewed-on: https://chromium-review.googlesource.com/1108242 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570227} [modify] https://crrev.com/47d5537ba10dd8b11c1402ac3e451940b5035724/components/subresource_filter/content/browser/verified_ruleset_dealer.cc [modify] https://crrev.com/47d5537ba10dd8b11c1402ac3e451940b5035724/components/subresource_filter/core/browser/ruleset_service.cc [modify] https://crrev.com/47d5537ba10dd8b11c1402ac3e451940b5035724/components/subresource_filter/core/browser/ruleset_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0855ce5d8e550e243803522771e4c7ed5aec81a commit d0855ce5d8e550e243803522771e4c7ed5aec81a Author: Charlie Harrison <csharrison@chromium.org> Date: Mon Jul 09 18:52:39 2018 Trace validity + size during ruleset verification TBR=jkarlin@chromium.org Bug: 721512 Change-Id: Ia9d793aae153328d6ec7602f056017a3a6a93928 Reviewed-on: https://chromium-review.googlesource.com/1129325 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#573391} [modify] https://crrev.com/d0855ce5d8e550e243803522771e4c7ed5aec81a/components/subresource_filter/core/common/indexed_ruleset.cc
Comment 1 by bugdroid1@chromium.org
, May 15 2017