Crash when adding a billing address for a card. |
|||||||
Issue descriptionChrome Version : 60.0.3088.3 What steps will reproduce the problem? 1. Click on "Add" for the billing address field in the address editor for a local card 4111 1111 1111 1111. 2. Type in the name "Jon Doe". 3. Select the country "Cyprus". 4) Type in the rest of the address: "123 Main St", "Escaban", "12345", "555 5555 5555". 5) Click "Done" in the address editor. What is the expected result? No crash. What happens instead of that? Crash. [27291:27291:0511/152829.201702:FATAL:shipping_address_editor_view_controller.cc(337)] Check failed: success || ignore_errors. Can't setinfo(14, 555 555 5555 [95/9381] #0 0x7f65a5b8e84b base::debug::StackTrace::StackTrace() #1 0x7f65a5b8d54c base::debug::StackTrace::StackTrace() #2 0x7f65a5c00da3 logging::LogMessage::~LogMessage() #3 0x55aa06e6ac2b payments::ShippingAddressEditorViewController::SaveFieldsToProfile() #4 0x55aa06e6a6a1 payments::ShippingAddressEditorViewController::ValidateModelAndSave() #5 0x55aa07130f36 payments::EditorViewController::ButtonPressed() #6 0x7f6599d34927 views::Button::NotifyClick() #7 0x7f6599d37877 views::CustomButton::NotifyClick() #8 0x7f6599d36966 views::CustomButton::OnMouseReleased() #9 0x7f6599e1f742 views::View::ProcessMouseReleased() #10 0x7f6599e1efc7 views::View::OnMouseEvent() #11 0x7f6599d08326 views::InkDropHostView::OnMouseEvent() #12 0x7f659b7cc403 ui::EventHandler::OnEvent() #13 0x7f659b7c7ba0 ui::EventDispatcher::DispatchEvent() #14 0x7f659b7c748b ui::EventDispatcher::ProcessEvent() #15 0x7f659b7c7222 ui::EventDispatcherDelegate::DispatchEventToTarget() #16 0x7f659b7c70cf ui::EventDispatcherDelegate::DispatchEvent() #17 0x7f6599e3df56 views::internal::RootView::OnMouseReleased() #18 0x7f6599e4635c views::Widget::OnMouseEvent() #19 0x7f6599e9a2e3 views::NativeWidgetAura::OnMouseEvent() #20 0x7f659b7cc403 ui::EventHandler::OnEvent() #21 0x7f659b7c7ba0 ui::EventDispatcher::DispatchEvent() #22 0x7f659b7c748b ui::EventDispatcher::ProcessEvent() #23 0x7f659b7c7222 ui::EventDispatcherDelegate::DispatchEventToTarget() #24 0x7f659b7c70cf ui::EventDispatcherDelegate::DispatchEvent() #25 0x7f659b7cd265 ui::EventProcessor::OnEventFromSource() #26 0x7f659b7cd3ec ui::EventProcessor::OnEventFromSource() #27 0x7f659b7ce3cf ui::EventSource::DeliverEventToSink() #28 0x7f659b7cdfd7 ui::EventSource::SendEventToSink() #29 0x7f6599ebc215 views::DesktopWindowTreeHostX11::DispatchMouseEvent() #30 0x7f6599ebd32f views::DesktopWindowTreeHostX11::DispatchEvent() #31 0x7f65a2bab10d ui::PlatformEventSource::DispatchEvent() #32 0x7f658c8b82b4 ui::X11EventSourceGlib::ProcessXEvent() [62/9381] #33 0x7f658c8a95b8 ui::X11EventSource::ExtractCookieDataDispatchEvent() #34 0x7f658c8a9520 ui::X11EventSource::DispatchXEvents() #35 0x7f658c8b8455 ui::(anonymous namespace)::XSourceDispatch() #36 0x7f658f6e2ce5 g_main_context_dispatch #37 0x7f658f6e3048 <unknown> #38 0x7f658f6e30ec g_main_context_iteration #39 0x7f65a5c39b2f base::MessagePumpGlib::Run() #40 0x7f65a5c26602 base::MessageLoop::RunHandler() #41 0x7f65a5ccddda base::RunLoop::Run() #42 0x55aa04ca045e ChromeBrowserMainParts::MainMessageLoopRun() #43 0x7f659ef7ff58 content::BrowserMainLoop::RunMainMessageLoopParts() #44 0x7f659ef8c696 content::BrowserMainRunnerImpl::Run() #45 0x7f659ef794d8 content::BrowserMain() #46 0x7f65a08b8f36 content::RunNamedProcessTypeMain() #47 0x7f65a08bb27d content::ContentMainRunnerImpl::Run() #48 0x7f65a08b79da content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #49 0x7f65a602f411 service_manager::Main() #50 0x7f65a08b898f content::ContentMain() #51 0x55aa031810aa ChromeMain #52 0x55aa03180fd2 main #53 0x7f658cd70f45 __libc_start_main #54 0x55aa03180eb4 <unknown> Received signal 6 #0 0x7f65a5b8e84b base::debug::StackTrace::StackTrace() #1 0x7f65a5b8d54c base::debug::StackTrace::StackTrace() #2 0x7f65a5b8e35f base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f65a61fe330 <unknown> #4 0x7f658cd85c37 gsignal #5 0x7f658cd89028 abort #6 0x7f65a5b8b546 base::debug::(anonymous namespace)::DebugBreak() #7 0x7f65a5b8b528 base::debug::BreakDebugger() #8 0x7f65a5c01224 logging::LogMessage::~LogMessage() [29/9381] #9 0x55aa06e6ac2b payments::ShippingAddressEditorViewController::SaveFieldsToProfile() #10 0x55aa06e6a6a1 payments::ShippingAddressEditorViewController::ValidateModelAndSave() #11 0x55aa07130f36 payments::EditorViewController::ButtonPressed() #12 0x7f6599d34927 views::Button::NotifyClick() #13 0x7f6599d37877 views::CustomButton::NotifyClick() #14 0x7f6599d36966 views::CustomButton::OnMouseReleased() #15 0x7f6599e1f742 views::View::ProcessMouseReleased() #16 0x7f6599e1efc7 views::View::OnMouseEvent() #17 0x7f6599d08326 views::InkDropHostView::OnMouseEvent() #18 0x7f659b7cc403 ui::EventHandler::OnEvent() #19 0x7f659b7c7ba0 ui::EventDispatcher::DispatchEvent() #20 0x7f659b7c748b ui::EventDispatcher::ProcessEvent() #21 0x7f659b7c7222 ui::EventDispatcherDelegate::DispatchEventToTarget() #22 0x7f659b7c70cf ui::EventDispatcherDelegate::DispatchEvent() #23 0x7f6599e3df56 views::internal::RootView::OnMouseReleased() #24 0x7f6599e4635c views::Widget::OnMouseEvent() #25 0x7f6599e9a2e3 views::NativeWidgetAura::OnMouseEvent() #26 0x7f659b7cc403 ui::EventHandler::OnEvent() #27 0x7f659b7c7ba0 ui::EventDispatcher::DispatchEvent() #28 0x7f659b7c748b ui::EventDispatcher::ProcessEvent() #29 0x7f659b7c7222 ui::EventDispatcherDelegate::DispatchEventToTarget() #30 0x7f659b7c70cf ui::EventDispatcherDelegate::DispatchEvent() #31 0x7f659b7cd265 ui::EventProcessor::OnEventFromSource() #32 0x7f659b7cd3ec ui::EventProcessor::OnEventFromSource() #33 0x7f659b7ce3cf ui::EventSource::DeliverEventToSink() #34 0x7f659b7cdfd7 ui::EventSource::SendEventToSink() #35 0x7f6599ebc215 views::DesktopWindowTreeHostX11::DispatchMouseEvent() #36 0x7f6599ebd32f views::DesktopWindowTreeHostX11::DispatchEvent() #37 0x7f65a2bab10d ui::PlatformEventSource::DispatchEvent() #38 0x7f658c8b82b4 ui::X11EventSourceGlib::ProcessXEvent() #39 0x7f658c8a95b8 ui::X11EventSource::ExtractCookieDataDispatchEvent() #40 0x7f658c8a9520 ui::X11EventSource::DispatchXEvents() #41 0x7f658c8b8455 ui::(anonymous namespace)::XSourceDispatch() #42 0x7f658f6e2ce5 g_main_context_dispatch #43 0x7f658f6e3048 <unknown> #44 0x7f658f6e30ec g_main_context_iteration #45 0x7f65a5c39b2f base::MessagePumpGlib::Run() #46 0x7f65a5c26602 base::MessageLoop::RunHandler() #47 0x7f65a5ccddda base::RunLoop::Run() #48 0x55aa04ca045e ChromeBrowserMainParts::MainMessageLoopRun() #49 0x7f659ef7ff58 content::BrowserMainLoop::RunMainMessageLoopParts() #50 0x7f659ef8c696 content::BrowserMainRunnerImpl::Run() #51 0x7f659ef794d8 content::BrowserMain() #52 0x7f65a08b8f36 content::RunNamedProcessTypeMain() #53 0x7f65a08bb27d content::ContentMainRunnerImpl::Run() #54 0x7f65a08b79da content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #55 0x7f65a602f411 service_manager::Main() #56 0x7f65a08b898f content::ContentMain() #57 0x55aa031810aa ChromeMain #58 0x55aa03180fd2 main #59 0x7f658cd70f45 __libc_start_main #60 0x55aa03180eb4 <unknown> r8: fffffffffffffed8 r9: fffffffffffffec8 r10: 0000000000000008 r11: 0000000000000202 r12: 00000db818f017a0 r13: 00007f658f9a0920 r14: 00007f658c8b8430 r15: 00000db81919da70 di: 0000000000006a9b si: 0000000000006a9b bp: 00007ffc7be515a0 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: 00007f658cd85c37 sp: 00007ffc7be51468 ip: 00007f658cd85c37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3088.3 Safari/537.36
,
May 11 2017
Looks like a failed DHCECK(), so not a release blocker, but should be investigated nonetheless. Saving autofill data should not have a reason to fail.
,
May 11 2017
Mad looked at this exact issue. Let me try to repro on ToT.
,
May 11 2017
Does not have to be Cyprus. Just clicking "Done" will attempt to save the profile without validating it first. Then hit the DCHECK().
,
May 11 2017
Ho! I shouldn't have left these DCHECKs in there sorry. I'll remove them, it was mainly for debugging. I'll add DLOG_IF instead.
,
May 11 2017
Please make sure validation happens before [Done] button is allowed to proceed :D
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b69e051f0d66a92428423df72843d0d53ccbd6cd commit b69e051f0d66a92428423df72843d0d53ccbd6cd Author: mad <mad@chromium.org> Date: Thu May 11 22:28:32 2017 DCHECK -> LOG_IF in payment request shipping address BUG= 721502 Review-Url: https://codereview.chromium.org/2875103003 Cr-Commit-Position: refs/heads/master@{#471091} [modify] https://crrev.com/b69e051f0d66a92428423df72843d0d53ccbd6cd/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
,
May 16 2017
Verified this issue on Ubuntu 14.04 with chrome #60.0.3100.0 as per steps mentioned in Comment #0 Didn't observe any crash while clicking the done in the editor. Attaching a screen-cast for reference, Hence adding TE-verified labels "TE-Verified-60.0.3100.0 Verified this issue on Ubuntu 14.04 with chrome #60.0.3100.0 as per steps mentioned in Comment #0 Didn't observe any crash while clicking the done in the editor. Attaching a screen-cast for reference, Hence adding TE-verified labels
,
May 17 2017
,
Jun 27 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by anthonyvd@chromium.org
, May 11 2017Owner: ma...@chromium.org
Status: Assigned (was: Untriaged)