Clicking "Add billing address" should invoke the address editor |
|||||
Issue descriptionChrome Version : 60.0.3088.3 What steps will reproduce the problem? 1. Erase all addresses from your autofill profile. 2. Make sure your autofill profile has a single card without a billing address. 3. Open https://rsolomakhin.github.io/pr/type/debit/ 4. Click "Buy" on page. 5. Edit the card. 6. Open the "Add a billing address" dropdown. 7. Click "Add a billing address" item in the dropdown. What is the expected result? I expect the address editor to open. What happens instead of that? The "Add a billing address" item does not trigger any actions in the dropdown. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3088.3 Safari/537.36
,
May 11 2017
+mad who added this dropdown. +bbergher: Bruno, what should the UI look like when there's no available address? I feel like it'd be a better experience for the dropdown to be disabled in that case since the "Add" button already opens the editor.
,
May 12 2017
Yup, I agree with the solution and that the dropdown should be disabled, perhaps with text saying something along the lines of "No saved addresses"
,
May 17 2017
Over to mad, expert on this dropdown :) Can you please take a look?
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5022bd5a5c78faa35e4236abb37dd67b86b9cf44 commit 5022bd5a5c78faa35e4236abb37dd67b86b9cf44 Author: mad <mad@chromium.org> Date: Fri May 19 14:45:09 2017 Change text and disable empty combobox for payment request shipping address BUG= 721500 Review-Url: https://codereview.chromium.org/2888733004 Cr-Commit-Position: refs/heads/master@{#473186} [modify] https://crrev.com/5022bd5a5c78faa35e4236abb37dd67b86b9cf44/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/5022bd5a5c78faa35e4236abb37dd67b86b9cf44/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h [modify] https://crrev.com/5022bd5a5c78faa35e4236abb37dd67b86b9cf44/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [modify] https://crrev.com/5022bd5a5c78faa35e4236abb37dd67b86b9cf44/chrome/browser/ui/views/payments/editor_view_controller.cc [modify] https://crrev.com/5022bd5a5c78faa35e4236abb37dd67b86b9cf44/components/autofill/core/browser/address_combobox_model.cc [modify] https://crrev.com/5022bd5a5c78faa35e4236abb37dd67b86b9cf44/components/autofill_strings.grdp
,
May 19 2017
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rouslan@chromium.org
, May 11 2017