"Recently closed" category of JumpList doesn't show up after Chrome launches |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Launch Chrome and use a little bit (open and close more than 3 tabs) (2) Right click its icon on the task bar to show jumplist and it will look like figure 1. There are 5 icons for "most visited" category and 3 for "recently closed" category. (3) Shut Chrome down and re-launch it, show the jumplist. What is the expected result after step 3? The "Recently closed" category should still show up in the JumpList and remain the same as figure 1, as neither one of the two categories has changes. What happens instead? The "Recently closed" category doesn't show up. All its slots are given to the "most visited" category, which now shows 9 icons. See figure 2. Note that if opening and closing tabs after step (3), the new "Recently closed" icons will start to show up.
,
May 11 2017
,
May 18 2017
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55c71f0ff307dfc3b3e561a2f72e90bb3df05393 commit 55c71f0ff307dfc3b3e561a2f72e90bb3df05393 Author: chengx <chengx@chromium.org> Date: Mon May 22 23:41:32 2017 Defer syncing TopSites with history until the first tab closure This change defers syncing TopSites with history until the first tab closure and ignores any TopSites updates that arrive before that time. It also makes the category titles ever-present in the JumpList and removes the old balancing strategy that used to show more most visited items when there were fewer than 3 recently closed items. The JumpList will now retain its items from a previous launch until the first tab closure, making it more useful early on in the browser's lifetime. Also, there will be no unnecessary TopSites syncs now if an user launches Chrome but shuts it down before opening any tabs. After that initial tab closure, all old recently closed items are lost as it is not possible to query Windows for them. Removal of the balancing strategy trims out waste resulting from fetching 9 items initially, which are then trimmed down as tabs are closed. BUG= 721484 , 721486 Review-Url: https://codereview.chromium.org/2865133003 Cr-Commit-Position: refs/heads/master@{#473747} [modify] https://crrev.com/55c71f0ff307dfc3b3e561a2f72e90bb3df05393/chrome/browser/win/jumplist.cc [modify] https://crrev.com/55c71f0ff307dfc3b3e561a2f72e90bb3df05393/chrome/browser/win/jumplist.h
,
May 22 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by chengx@chromium.org
, May 11 2017