JumpList creates 9 icons right after Chrome launches and discards 4+ of them shortly, which is very inefficient |
||
Issue descriptionWhat steps will reproduce the problem? (1) Launch Chrome and use a little bit (open and close more than 3 tabs). Then there're typically 5 icons in JumpListIconsMostVisited folder and 3 icons in JumpListIconsRecentClosed folder. This corresponds to that now JumpList shows 5 most visited jumplist items and 3 recently closed items. (2) Shut down Chrome and re-launch it. Now there're 9 icons in JumpListIconsMostVisited folder and 0 in JumpListIconsRecentClosed folder. (3) Use a little bit (open and close more than 3 tabs). Now there're 5 in JumpListIconsMostVisited and 3 in JumpListIconsRecentClosed. Between step (2) and (3), we are wasting 4 icons no matter what. This is very inefficient. The 9 icons' creation in step (2) can be avoided.
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55c71f0ff307dfc3b3e561a2f72e90bb3df05393 commit 55c71f0ff307dfc3b3e561a2f72e90bb3df05393 Author: chengx <chengx@chromium.org> Date: Mon May 22 23:41:32 2017 Defer syncing TopSites with history until the first tab closure This change defers syncing TopSites with history until the first tab closure and ignores any TopSites updates that arrive before that time. It also makes the category titles ever-present in the JumpList and removes the old balancing strategy that used to show more most visited items when there were fewer than 3 recently closed items. The JumpList will now retain its items from a previous launch until the first tab closure, making it more useful early on in the browser's lifetime. Also, there will be no unnecessary TopSites syncs now if an user launches Chrome but shuts it down before opening any tabs. After that initial tab closure, all old recently closed items are lost as it is not possible to query Windows for them. Removal of the balancing strategy trims out waste resulting from fetching 9 items initially, which are then trimmed down as tabs are closed. BUG= 721484 , 721486 Review-Url: https://codereview.chromium.org/2865133003 Cr-Commit-Position: refs/heads/master@{#473747} [modify] https://crrev.com/55c71f0ff307dfc3b3e561a2f72e90bb3df05393/chrome/browser/win/jumplist.cc [modify] https://crrev.com/55c71f0ff307dfc3b3e561a2f72e90bb3df05393/chrome/browser/win/jumplist.h
,
May 22 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chengx@chromium.org
, May 11 2017