New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721481 link

Starred by 1 user
Status: Verified
Owner:
█ pho...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
akes...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

An end-to-end test for apache_error_log_metrics would be nice

Project Member Reported by pho...@chromium.org, May 11 2017 
Add a flag to send metrics to a file, and make a unit test which shells out to the script and checks that the correct metrics were emitted.
Project Member

Comment 1 by bugdroid1@chromium.org, May 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3358c52046874b3929b5ff1df723e1ddd8d60082

commit 3358c52046874b3929b5ff1df723e1ddd8d60082
Author: Paul Hobbs <phobbs@google.com>
Date: Sat May 13 03:58:00 2017

[autotest] Functional test apache_error_log_metrics

Added a flag --debug-metrics-file to apache_error_log_metrics, which
allows it to send metrics to a file instead of production.

Added a unit test using --debug-metrics-file which tests the script
end-to-end.

BUG= chromium:721481 
TEST=The new unit test passes.

Change-Id: I239a89e0089d28cb31613c06f05bd79434d9a739
Reviewed-on: https://chromium-review.googlesource.com/503528
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/3358c52046874b3929b5ff1df723e1ddd8d60082/site_utils/stats/apache_error_log_metrics_unittest.py
[modify] https://crrev.com/3358c52046874b3929b5ff1df723e1ddd8d60082/site_utils/stats/apache_error_log_metrics.py

Comment 2 by pho...@chromium.org, May 16 2017

Status: Verified (was: Started)
►

Sign in to add a comment