PhotoCapabilities |width| and |height| shouldn't be zero |
|||||
Issue description... in platforms where the capture resolution isn't configurable, but instead provide a |min| == |max| == capture resolution (and |step| = 0). Currently it returns null: PhotoCapabilities fillLightMode : Array(0) imageHeight : null imageWidth : null redEyeReduction : "never"
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68edd5fc2eb0f6ccdf0680870f89471f5e5ecfa4 commit 68edd5fc2eb0f6ccdf0680870f89471f5e5ecfa4 Author: mcasas <mcasas@chromium.org> Date: Thu May 11 23:56:49 2017 Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac This CL wires the GetPhotoCapabibilities() method for Mac and fills in the only available capability, the photo resolution, which is equal to the "live" capture resolution. This CL also fills in the Linux/CrOs capture reoslution as the only supported PhotoCapabilities.{height,width}. BUG= 721478 Review-Url: https://codereview.chromium.org/2868393004 Cr-Commit-Position: refs/heads/master@{#471128} [modify] https://crrev.com/68edd5fc2eb0f6ccdf0680870f89471f5e5ecfa4/media/capture/video/linux/v4l2_capture_delegate.cc [modify] https://crrev.com/68edd5fc2eb0f6ccdf0680870f89471f5e5ecfa4/media/capture/video/mac/video_capture_device_mac.h [modify] https://crrev.com/68edd5fc2eb0f6ccdf0680870f89471f5e5ecfa4/media/capture/video/mac/video_capture_device_mac.mm
,
May 12 2017
Verified in Chrome 60.3098.0 for Mac.
,
May 16 2017
,
May 16 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf88c011d24a48713729607f838a10fb5bd6892e commit cf88c011d24a48713729607f838a10fb5bd6892e Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Tue May 16 18:21:57 2017 Image Capture: fill in PhotoCapabilities.{height,width} in Linux/CrOs/Mac This CL wires the GetPhotoCapabibilities() method for Mac and fills in the only available capability, the photo resolution, which is equal to the "live" capture resolution. This CL also fills in the Linux/CrOs capture reoslution as the only supported PhotoCapabilities.{height,width}. BUG= 721478 Review-Url: https://codereview.chromium.org/2868393004 Cr-Original-Commit-Position: refs/heads/master@{#471128} Review-Url: https://codereview.chromium.org/2888613002 . Cr-Commit-Position: refs/branch-heads/3071@{#587} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/cf88c011d24a48713729607f838a10fb5bd6892e/media/capture/video/linux/v4l2_capture_delegate.cc [modify] https://crrev.com/cf88c011d24a48713729607f838a10fb5bd6892e/media/capture/video/mac/video_capture_device_mac.h [modify] https://crrev.com/cf88c011d24a48713729607f838a10fb5bd6892e/media/capture/video/mac/video_capture_device_mac.mm |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mcasas@chromium.org
, May 11 2017