New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721457 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 680153



Sign in to add a comment

Adjust chromeos-ec to support unified builds when no source exists

Project Member Reported by sjg@chromium.org, May 11 2017

Issue description

With go/croscl/452459 we removed the EC source code for pyro and snappy.

Unified builds needs to be able to build the EC for reef, pyro and snappy, but cannot if there is no source. In practice this doesn't matter because:

- devs will work on a reef branch, where the source is available
- the output of the chromeos-ec is not actually used to produce a firmware image. Instead, a separate firmware builder produces this output and uploads it to BCS.
- in practice on ToT on pyro EC is not actually build. Instead it builds 'bds'. This is because EC_BOARD_NAMES in cros-ec-board.eclass does not include 'pyro', so get_ec_boards() will never return that

So in practice we just need to produce *something* as output for each board from chromeos-ec. The easier solution is just to copy reef to pyro and snappy.

 

Comment 1 by sjg@chromium.org, May 11 2017

Blocking: 680153

Comment 2 by sjg@chromium.org, May 11 2017

Owner: sjg@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7d1d441c5231a55df8223921920bbc4485651af9

commit 7d1d441c5231a55df8223921920bbc4485651af9
Author: Simon Glass <sjg@chromium.org>
Date: Tue May 23 02:31:20 2017

chromeos-ec: Support unified builds when source is missing

We cannot currently build chromeos-ec with:

   USE=unibuild emerge-reef chromeos-ec

This is because it tries to build pyro and snappy as well, and the souce
code for those is not present in ToT.

Work around this by adding a new EC_FIRMWARE_UNIBUILD_FAKE setting,
specifying firmware that is not built, but is in fact copied over from
the board which is present in ToT.

More details are in the bug.

BUG= chromium:721457 
TEST=./build_packages --board=reef-uni --nowithautotest --noworkon
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: I4edf5006dba27d631eee278230d695b1efab0956
Reviewed-on: https://chromium-review.googlesource.com/503468
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/7d1d441c5231a55df8223921920bbc4485651af9/chromeos-base/chromeos-ec/chromeos-ec-9999.ebuild

Comment 4 by sjg@chromium.org, Jun 1 2017

Status: Fixed (was: Available)

Sign in to add a comment